8000 Fix precission when tickSize = 2.5 (fix null reference) by tomkooij · Pull Request #1785 · flot/flot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix precission when tickSize = 2.5 (fix null reference) #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2021
Merged

Fix precission when tickSize = 2.5 (fix null reference) #1785

merged 1 commit into from
Jul 16, 2021

Conversation

tomkooij
Copy link
Contributor
@tomkooij tomkooij commented Jun 25, 2021 •
edited
Loading

Issue: ticks: 0 - 0.25 - 0.5 - 0.75 - 1 will be incorrectly rounded to 0 - 0.3 - 0.5 - 0.8 - 1

This is visible in the examples: http://www.flotcharts.org/flot/examples/axes-tickLabels/index.html
image
In the image above the horizontal ticks should be 10017.00 - 10017.25 - x.50 - x.75 etc.

This is caused by a null reference to axis.tickDecimals. When this is null the extra decimal for tickRange 2.5 is not added.

@tomkooij
Fix null reference
3e06132 
When tickDecimals is null adding an extra tickdecimal when range is .25
will fail.

0 - 0.25 - 0.5 - 0.75 - 1 will be incorrectly rounded to 0 - 0.3 - 0.5 - 0.8
@atmgrifter00 atmgrifter00 self-requested a review July 16, 2021 14:23
@atmgrifter00 atmgrifter00 merged commit 370cf6e into flot:master Jul 16, 2021
@atmgrifter00
Copy link
Contributor

I'll make a new version of flot shortly (might wait until another bug gets addressed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomkooij @atmgrifter00
0