feat: update ic-js for new nns did and last didc #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
approved these changes
Sep 20, 2022
peterpeterparker
added a commit
that referenced
this pull request
Sep 22, 2022
# Motivation Follow-up of #1347 which was auto-merged even though tests were failing. # Changes - adapt tests for new candid files generated with last didc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update ic-js libraries that contains the upgrade to recent version of
didcand the did files for the last commit of the ICPR
Changes
nns-js,sns-jsandutils-js