8000 feat: update nns did and didc by peterpeterparker · Pull Request #189 · dfinity/ic-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: update nns did and didc #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Sep 22, 2022
Merged

Conversation

peterpeterparker
Copy link
Member
@peterpeterparker peterpeterparker commented Sep 19, 2022

Motivation

Update NNS did files with last IC commit and bump didc.

Important note ⚠️

This upgrade is not backwards compatible and runs only on a NNS governance canister code upgraded.

Changes

  • bump didc in Github actions
  • update code for didc breaking changes
  • update NNS did files
  • add OpenSnsTokenSwap, StakeMaturity and ChangeAutoStakeMaturity to NNS governance converters
  • more array utilities to utils
  • adapt some utility functions for new didc

Copy link
Contributor
@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments but already approving.

LGTM, thanks!

@peterpeterparker peterpeterparker marked this pull request as draft September 21, 2022 11:38
@peterpeterparker peterpeterparker marked this pull request as ready for review September 22, 2022 05:09
@peterpeterparker peterpeterparker merged commit eee94d4 into main Sep 22, 2022
@peterpeterparker peterpeterparker deleted the feat/update-nns-did-and-didc branch September 22, 2022 05:13
lmuntaner added a commit that referenced this pull request Jan 18, 2023
lmuntaner added a commit that referenced this pull request Jan 27, 2023
lmuntaner added a commit that referenced this pull request Jan 31, 2023
lmuntaner added a commit that referenced this pull request Jan 31, 2023
lmuntaner added a commit that referenced this pull request Mar 21, 2023
lmuntaner added a commit that referenced this pull request May 11, 2023
lmuntaner added a commit that referenced this pull request Jul 12, 2023
lmuntaner added a commit that referenced this pull request Sep 21, 2023
lmuntaner added a commit that referenced this pull request Oct 3, 2023
lmuntaner added a commit that referenced this pull request Feb 4, 2024
lmuntaner added a commit that referenced this pull request Jul 23, 2024
lmuntaner added a commit that referenced this pull request Oct 7, 2024
lmuntaner added a commit that referenced this pull request Nov 14, 2024
lmuntaner added a commit that referenced this pull request Nov 22, 2024
lmuntaner added a commit that referenced this pull request Dec 18, 2024
lmuntaner added a commit that referenced this pull request Feb 5, 2025
lmuntaner added a commit that referenced this pull request Mar 19, 2025
lmuntaner added a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0