8000 refactor(portfolio): migrate balance cards to runes by yhabib · Pull Request #6853 · dfinity/nns-dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(portfolio): migrate balance cards to runes #6853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

refactor(portfolio): migrate balance cards to runes #6853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e9f733
migrate components
yhabib May 19, 2025
a8a3e1c
migrate slots
yhabib May 19, 2025
f79c0c4
fix issue with slot
yhabib May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions frontend/src/lib/components/portfolio/HeldTokensCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,22 @@
import { IconAccountsPage, IconHeldTokens } from "@dfinity/gix-components";
import { TokenAmountV2 } from "@dfinity/utils";

export let topHeldTokens: UserTokenData[];
export let usdAmount: number;
export let numberOfTopStakedTokens: number;
type Props = {
topHeldTokens: UserTokenData[];
usdAmount: number;
numberOfTopStakedTokens: number;
};
const { topHeldTokens, usdAmount, numberOfTopStakedTokens }: Props = $props();

const href = AppPath.Tokens;

let numberOfTopHeldTokens: number;
$: numberOfTopHeldTokens = topHeldTokens.length;

let showInfoRow: boolean;
$: showInfoRow = shouldShowInfoRow({
currentCardNumberOfTokens: numberOfTopHeldTokens,
otherCardNumberOfTokens: numberOfTopStakedTokens,
});
const numberOfTopHeldTokens = $derived(topHeldTokens.length);
const showInfoRow = $derived(
shouldShowInfoRow({
currentCardNumberOfTokens: numberOfTopHeldTokens,
otherCardNumberOfTokens: numberOfTopStakedTokens,
})
);
</script>

<Card testId="held-tokens-card">
Expand All @@ -41,9 +43,9 @@
title={$i18n.portfolio.held_tokens_card_title}
linkText={$i18n.portfolio.held_tokens_card_link}
>
<svelte:fragment slot="icon">
{#snippet icon()}
<IconHeldTokens />
</svelte:fragment>
{/snippet}
</TokensCardHeader>
<div class="body" role="table">
<div class="header" role="row">
Expand Down
28 changes: 16 additions & 12 deletions frontend/src/lib/components/portfolio/StakedTokensCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,24 @@
import { IconNeuronsPage, IconStakedTokens } from "@dfinity/gix-components";
import { TokenAmountV2 } from "@dfinity/utils";

export let topStakedTokens: TableProject[];
export let usdAmount: number;
export let numberOfTopHeldTokens: number;
type Props = {
topStakedTokens: TableProject[];
usdAmount: number;
numberOfTopHeldTokens: number;
};

const { topStakedTokens, usdAmount, numberOfTopHeldTokens }: Props = $props();

const href = AppPath.Staking;

let numberOfTopStakedTokens: number;
$: numberOfTopStakedTokens = topStakedTokens.length;
const numberOfTopStakedTokens = $derived(topStakedTokens.length);

let showInfoRow: boolean;
$: showInfoRow = shouldShowInfoRow({
currentCardNumberOfTokens: numberOfTopStakedTokens,
otherCardNumberOfTokens: numberOfTopHeldTokens,
});
const showInfoRow = $derived(
shouldShowInfoRow({
currentCardNumberOfTokens: numberOfTopStakedTokens,
otherCardNumberOfTokens: numberOfTopHeldTokens,
})
);
</script>

<Card testId="staked-tokens-card">
Expand All @@ -42,9 +46,9 @@
title={$i18n.portfolio.staked_tokens_card_title}
linkText={$i18n.portfolio.staked_tokens_card_link}
>
<svelte:fragment slot="icon">
{#snippet icon()}
<IconNeuronsPage />
</svelte:fragment>
{/snippet}
</TokensCardHeader>
<div class="body" role="table">
<div class="header" role="row">
Expand Down
25 changes: 16 additions & 9 deletions frontend/src/lib/components/portfolio/TokensCardHeader.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,29 @@
import { authSignedInStore } from "$lib/derived/auth.derived";
import { formatCurrencyNumber } from "$lib/utils/format.utils";
import { IconRight } from "@dfinity/gix-components";
import type { Snippet } from "svelte";

export let usdAmount: number;
export let href: string;
export let title: string;
export let linkText: string;
type Props = {
usdAmount: number;
href: string;
title: string;
linkText: string;
icon: Snippet;
};

let usdAmountFormatted: string;
$: usdAmountFormatted = $authSignedInStore
? formatCurrencyNumber(usdAmount)
: PRICE_NOT_AVAILABLE_PLACEHOLDER;
const { usdAmount, href, title, linkText, icon }: Props = $props();

const usdAmountFormatted = $derived(
$authSignedInStore
? formatCurrencyNumber(usdAmount)
: PRICE_NOT_AVAILABLE_PLACEHOLDER
);
</script>

<div class="header">
<div class="header-wrapper">
<div class="icon" aria-hidden="true">
<slot name="icon" />
{@render icon()}
</div>
<div class="text-content">
<h5 class="title">{title}</h5>
Expand Down
0