refactor(portfolio): migrate balance cards to runes #6853
Merged
+47
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
429c78e to
18d7b3e
Compare
18d7b3e to
10d9721
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the portfolio balance cards to use Svelte runes, paving the way for a toggle to show/hide balances. Key changes include migrating TokensCardHeader, StakedTokensCard, and HeldTokensCard to use the new Svelte runes syntax with updated prop handling and reactive declarations.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/lib/components/portfolio/TokensCardHeader.svelte | Migrates header component to use $props(), $derived, and new snippet rendering for the icon. |
| frontend/src/lib/components/portfolio/StakedTokensCard.svelte | Updates props handling with Svelte runes and replaces slot usage with snippet syntax for the icon. |
| frontend/src/lib/components/portfolio/HeldTokensCard.svelte | Converts props and reactive declarations to Svelte runes syntax and adjusts icon rendering using snippets. |
10d9721 to
f79c0c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to introduce a toggle that allows users to hide or show their balances on the main pages. This PR migrates the two cards displaying balances in the Portfolio page to use Svelte runes, simplifying future changes to implement the visibility toggle.
NNS1-3721
Changes
HeldTokensCardto runes.StakedTokensCardto runes.TokensCardHeaderto runes.Tests
Todos
Not necessary.