8000 feat(store): add balance visibility logic by yhabib · Pull Request #6839 · dfinity/nns-dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(store): add balance visibility logic #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

< 8000 a href="#issue-comment-box" class="py-1">Jump to bottom
Merged
merged 4 commits into from
May 19, 2025
Merged

feat(store): add balance visibility logic #6839

merged 4 commits into from
May 19, 2025
+52 −3

Conversation

yhabib
Copy link
Contributor
@yhabib yhabib commented May 15, 2025

Motivation

We want to introduce a toggle that allows users to hide or show their balances on the main pages. This PR adds a new derived store to determine whether the balances should be visible. The logic is as follows:

  • If the user is signed in and has marked the option to hide the balance, it will return true.
  • In all other cases, it will return false.

NNS1-3721

Changes

  • Add new derived store.

Tests

  • Add unit tests for the derived store.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@yhabib yhabib changed the base branch from main to nns1-3721/writable-store May 15, 2025 20:34
@yhabib yhabib marked this pull request as ready for review May 15, 2025 20:34
@yhabib yhabib requested a review from a team as a code owner May 15, 2025 20:34
mstrasinskis
mstrasinskis approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mstrasinskis mstrasinskis mentioned this pull request May 16, 2025
Merged
1 task
Base automatically changed from nns1-3721/writable-store to main May 19, 2025 10:47
@yhabib yhabib force-pushed the nns1-3721/derived-store branch from a66fcf0 to 0885271 Compare May 19, 2025 10:59
@yhabib yhabib enabled auto-merge May 19, 2025 11:11
@yhabib yhabib added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit ea1fdfe May 19, 2025
36 checks passed
@yhabib yhabib deleted the nns1-3721/derived-store branch May 19, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis
0