8000 feat(balances): add balance display settings store by yhabib · Pull Request #6838 · dfinity/nns-dapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(balances): add balance display settings store #6838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

feat(balances): add balance display settings store #6838

merged 3 commits into from
May 19, 2025

Conversation

yhabib
Copy link
Contributor
@yhabib yhabib commented May 15, 2025 •
edited by jira bot
Loading

Motivation

We want to introduce a toggle that allows users to hide or show their balances on the main pages. This PR introduces a new writable store, which is a store that is saved in local storage, to track the user's selection of hide/show.

NNS1-3721

Changes

  • Add new writable store.

Tests

  • Add unit tests for the store.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@yhabib yhabib marked this pull request as ready for review May 15, 2025 20:18
@yhabib yhabib requested a review from a team as a code owner May 15, 2025 20:18
mstrasinskis
mstrasinskis approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yhabib yhabib enabled auto-merge May 19, 2025 08:38
@yhabib yhabib added this pull request to the merge queue May 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 19, 2025
@yhabib yhabib added this pull request to the merge queue May 19, 2025
7360 Merged via the queue into main with commit 084d99b May 19, 2025
36 checks passed
@yhabib yhabib deleted the nns1-3721/writable-store branch May 19, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis
0