chore: hide typedef registration in progress output (and in CLI) #9434
Conversation
Hide these from the supported functions available on the command line (since they're for SDKs only). Additionally, move the helper for this into the `dagui` package, so that we can use it to hide output in the progress view - this has the largest impact when building complex modules in CI (which uses plain progress output), like in our own CI. Signed-off-by: Justin Chadwell <me@jedevc.com>
| @@ -102,3 +116,45 @@ func (opts FrontendOpts) ShouldShow(span *Span) bool { | |||
| } | |||
| return true | |||
| } | |||
|
|
|||
| func ShouldSkipFunction(obj, field string) bool { | |||
| // TODO: make this configurable in the API but may not be easy to | |||
There was a problem hiding this comment.
I have some code in #9327 for filtering that would be helpful here:
Feel free to carry on with this though - I can re-integrate + de-couple later.
I should try to land that PR though - maybe I'll just mark the API experimental for now.
There was a problem hiding this comment.
Ahh, that definitely looks useful 👀 Being able to filter it better would definitely help.
Any objection to landing this in the meantime though? I'm happy to refactor it to match the newer API once it lands 🎉
|
Ahh, yeah, I think that's probably okay. Would it be worth having a similar verbosity feature in the web view, like we have in the TUI? Would be very useful, as we do cleanups around #9476 (which'll probably result in more stuff getting hidden away). |
|
Yeah, in the web you could have filters which are more descriptive, like "☑️ Show internal spans". Would be nice to enable showing the SDK stuff for debugging, but I can turn that on in code since I'm already doing a custom dev build. |
Hide these from the supported functions available on the command line (since they're for SDKs only). Additionally, move the helper for this into the `dagui` package, so that we can use it to hide output in the progress view - this has the largest impact when building complex modules in CI (which uses plain progress output), like in our own CI. Signed-off-by: Justin Chadwell <me@jedevc.com>
Hide these from the supported functions available on the command line (since they're for SDKs only). Additionally, move the helper for this into the `dagui` package, so that we can use it to hide output in the progress view - this has the largest impact when building complex modules in CI (which uses plain progress output), like in our own CI. Signed-off-by: Justin Chadwell <me@jedevc.com>
Hide these from the supported functions available on the command line (since they're for SDKs only).
Additionally, move the helper for this into the
daguipackage, so that we can use it to hide output in the progress view - this has the largest impact when building complex modules in CI (which uses plain progress output), like in our own CI (for example: https://github.com/dagger/dagger/actions/runs/12928659633/job/36056419424#step:5:209)This was prompted by noticing our plain progress output has once again become kind of difficult to read - this is a fairly low hanging piece of fruit to tidy this up a bit.