add statuses API + Go/Python/TypeScript SDK support #9327
+4,792
−709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca6b043 to
708d96a
Compare
|
looking at the example traces, i can't tell– does this approach lose the ability for these traces to parent to a normal trace if users want to display them "normally" ? or is the idea that the CLI prioritizing showing this class of traces over the big ones and then links to both in cloud? |
8d5e2a5 to
39a81b7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@vito Please reopen this PR if this should be supported. Thanks |
This comment was marked as outdated.
This comment was marked as outdated.
wingyplus
reviewed
Apr 28, 2025
sdk/elixir/lib/dagger/gen/span.ex
Outdated
|
|
||
| @doc "Start a new instance of the span." | ||
| @spec start(t()) :: {:ok, Dagger.Span.t()} | {:error, term()} | ||
| def start(%__MODULE__{} = span) do |
There was a problem hiding this comment.
Oh, I don't need to implement OTel span, right?
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Alex Suraci <alex@dagger.io>
general idea is to keep building on Span primitive as the gateway to context propagation, and to provide a simplified dag.Reveal() API for revealing a bunch of spans without wrapping them (by using a passthrough dummy span). Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
This reverts commit 8b57e44. Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
…pendency management Signed-off-by: Tom Chauveau <tom@dagger.io>
Signed-off-by: Tom Chauveau <tom@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
sometimes this has unreleased APIs Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
* better docs * withActor -> withActorEmoji * add withReceivedMessage (a bit awkward, but when in Rome...) * remove withInternal; we don't really consistently support it yet, unsure if even needed update viztest along the way Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Signed-off-by: Alex Suraci <alex@dagger.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Global logging? Or do we just do spans?- let's do logging laterLogging to a span?- let's do logging later(internal, encapsulate, encapsulated)reveal/passthroughExpanded vs. collapsed by default?haven't needed this, 'reveal' covers it?Questions/TODOs
Examples
See the
viztest/changes for examples in Go, Python, and TypeScript.