8000 Add (de)serialization for ExtraOperatorInfo by NiclasHaderer · Pull Request #17563 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add (de)serialization for ExtraOperatorInfo #17563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/execution/operator/scan/physical_table_scan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ PhysicalTableScan::PhysicalTableScan(vector<LogicalType> types, TableFunction fu
: PhysicalOperator(PhysicalOperatorType::TABLE_SCAN, std::move(types), estimated_cardinality),
function(std::move(function_p)), bind_data(std::move(bind_data_p)), returned_types(std::move(returned_types_p)),
column_ids(std::move(column_ids_p)), projection_ids(std::move(projection_ids_p)), names(std::move(names_p)),
table_filters(std::move(table_filters_p)), extra_info(extra_info), parameters(std::move(parameters_p)),
table_filters(std::move(table_filters_p)), extra_info(std::move(extra_info)), parameters(std::move(parameters_p)),
virtual_columns(std::move(virtual_columns_p)) {
}

Expand Down
10 changes: 5 additions & 5 deletions src/execution/physical_plan/plan_get.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,10 @@ PhysicalOperator &PhysicalPlanGenerator::CreatePlan(LogicalGet &op) {
// create the table scan node
if (!op.function.projection_pushdown) {
// function does not support projection pushdown
auto &table_scan = Make<PhysicalTableScan>(op.returned_types, op.function, std::move(op.bind_data),
op.returned_types, column_ids, vector<column_t>(), op.names,
std::move(table_filters), op.estimated_cardinality, op.extra_info,
std::move(op.parameters), std::move(op.virtual_columns));
auto &table_scan = Make<PhysicalTableScan>(
op.returned_types, op.function, std::move(op.bind_data), op.returned_types, column_ids, vector<column_t>(),
op.names, std::move(table_filters), op.estimated_cardinality, std::move(op.extra_info),
std::move(op.parameters), std::move(op.virtual_columns));
// first check if an additional projection is necessary
if (column_ids.size() == op.returned_types.size()) {
bool projection_necessary = false;
Expand Down Expand Up @@ -188,7 +188,7 @@ PhysicalOperator &PhysicalPlanGenerator::CreatePlan(LogicalGet &op) {
auto &table_scan =
Make<PhysicalTableScan>(op.types, op.function, std::move(op.bind_data), op.returned_types, column_ids,
op.projection_ids, op.names, std::move(table_filters), op.estimated_cardinality,
op.extra_info, std::move(op.parameters), std::move(op.virtual_columns));
std::move(op.extra_info), std::move(op.parameters), std::move(op.virtual_columns));
auto &cast_table_scan = table_scan.Cast<PhysicalTableScan>();
cast_table_scan.dynamic_filters = op.dynamic_filters;
if (filter) {
Expand Down
25 changes: 23 additions & 2 deletions src/include/duckdb/common/extra_operator_info.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,33 @@ class ExtraOperatorInfo {
public:
ExtraOperatorInfo() : file_filters(""), sample_options(nullptr) {
}
ExtraOperatorInfo(ExtraOperatorInfo &extra_info)
: file_filters(extra_info.file_filters), sample_options(std::move(extra_info.sample_options)) {
ExtraOperatorInfo(ExtraOperatorInfo &&extra_info) noexcept
: file_filters(std::move(extra_info.file_filters)), sample_options(std::move(extra_info.sample_options)) {
if (extra_info.total_files.IsValid()) {
total_files = extra_info.total_files.GetIndex();
}
if (extra_info.filtered_files.IsValid()) {
filtered_files = extra_info.filtered_files.GetIndex();
}
}
ExtraOperatorInfo &operator=(ExtraOperatorInfo &&extra_info) noexcept {
if (this != &extra_info) {
file_filters = extra_info.file_filters;
if (extra_info.total_files.IsValid()) {
total_files = extra_info.total_files.GetIndex();
}
if (extra_info.filtered_files.IsValid()) {
filtered_files = extra_info.filtered_files.GetIndex();
}
sample_options = std::move(extra_info.sample_options);
}
return *this;
}

bool operator==(const ExtraOperatorInfo &other) const {
return file_filters == other.file_filters && total_files == other.total_files &&
filtered_files == other.filtered_files && sample_options == other.sample_options;
}

//! Filters that have been pushed down into the main file list
string file_filters;
Expand All @@ -39,6 +57,9 @@ class ExtraOperatorInfo {
optional_idx filtered_files;
//! Sample options that have been pushed down into the table scan
unique_ptr<SampleOptions> sample_options;

void Serialize(Serializer &serializer) const;
static ExtraOperatorInfo Deserialize(Deserializer &deserializer);
};

} // namespace duckdb
29 changes: 29 additions & 0 deletions src/include/duckdb/storage/serializat 10000 ion/nodes.json
Original file line number Diff line number Diff line change
Expand Up @@ -1106,5 +1106,34 @@
],
"pointer_type": "none",
"constructor": ["name", "type"]
},
{
"class": "ExtraOperatorInfo",
"includes": [
"duckdb/common/extra_operator_info.hpp"
],
"members": [
{
"id": 100,
"name": "file_filters",
"type": "string"
},
{
"id": 101,
"name": "total_files",
"type": "optional_idx"
},
{
"id": 102,
"name": "filtered_files",
"type": "optional_idx"
},
{
"id": 103,
"name": "sample_options",
"type": "unique_ptr<SampleOptions>"
}
],
"pointer_type": "none"
}
]
2 changes: 2 additions & 0 deletions src/planner/operator/logical_get.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ void LogicalGet::Serialize(Serializer &serializer) const {
}
serializer.WriteProperty(210, "projected_input", projected_input);
serializer.WritePropertyWithDefault(211, "column_indexes", column_ids);
serializer.WritePropertyWithDefault(212, "extra_info", extra_info, ExtraOperatorInfo {});
}

unique_ptr<LogicalOperator> LogicalGet::Deserialize(Deserializer &deserializer) {
Expand Down Expand Up @@ -256,6 +257,7 @@ unique_ptr<LogicalOperator> LogicalGet::Deserialize(Deserializer &deserializer)
result->column_ids.emplace_back(col_id);
}
}
result->extra_info = deserializer.ReadPropertyWithExplicitDefault<ExtraOperatorInfo>(212, "extra_info", {});
auto &context = deserializer.Get<ClientContext &>();
virtual_column_map_t virtual_columns;
if (!has_serialize) {
Expand Down
17 changes: 17 additions & 0 deletions src/storage/serialization/serialize_nodes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "duckdb/parser/parsed_data/exported_table_data.hpp"
#include "duckdb/common/column_index.hpp"
#include "duckdb/common/table_column.hpp"
#include "duckdb/common/extra_operator_info.hpp"

namespace duckdb {

Expand Down Expand Up @@ -302,6 +303,22 @@ ExportedTableInfo ExportedTableInfo::Deserialize(Deserializer &deserializer) {
return result;
}

void ExtraOperatorInfo::Serialize(Serializer &serializer) const {
serializer.WritePropertyWithDefault<string>(100, "file_filters", file_filters);
serializer.WriteProperty<optional_idx>(101, "total_files", total_files);
serializer.WriteProperty<optional_idx>(102, "filtered_files", filtered_files);
serializer.WritePropertyWithDefault<unique_ptr<SampleOptions>>(103, "sample_options", sample_options);
}

ExtraOperatorInfo ExtraOperatorInfo::Deserialize(Deserializer &deserializer) {
ExtraOperatorInfo result;
deserializer.ReadPropertyWithDefault<string>(100, "file_filters", result.file_filters);
deserializer.ReadProperty<optional_idx>(101, "total_files", result.total_files);
deserializer.ReadProperty<optional_idx>(102, "filtered_files", result.filtered_files);
deserializer.ReadPropertyWithDefault<unique_ptr<SampleOptions>>(103, "sample_options", result.sample_options);
return result;
}

void HivePartitioningIndex::Serialize(Serializer &serializer) const {
serializer.WritePropertyWithDefault<string>(100, "value", value);
serializer.WritePropertyWithDefault<idx_t>(101, "index", index);
Expand Down
Loading
0