Add (de)serialization for ExtraOperatorInfo #17563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! CI is quite overworked right now, could you perhaps verify locally that CI passes prior to un-drafting (https://github.com/NiclasHaderer/duckdb/tree/nh/serialization)? Once CI passes this is good to go from my side. |
|
I have just checked that "Test deserialized plans from file" works. All other tests should be fine, I think |
|
Unfortunately not :) can you have another look? |
|
Is this good to go? |
|
Yes, thanks |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Add (de)serialization for ExtraOperatorInfo (duckdb/duckdb#17563)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Add (de)serialization for ExtraOperatorInfo (duckdb/duckdb#17563)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 21, 2025
Add (de)serialization for ExtraOperatorInfo (duckdb/duckdb#17563)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 23, 2025
Add (de)serialization for ExtraOperatorInfo (duckdb/duckdb#17563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes over from #17518
In the sample pushdown, the SampleOptions are added to the extra_infos of the LogicalGet, but go missing when serializing the operator. This PR fixes this by adding serialization and deserialization for ExtraOperatorInfo. I hope that nodes.json is the right place to define the serialization for this type.
Furthermore, I changed the constructor of ExtraOperatorInfo to be a move constructor because it is moving a unique_ptr.