JSON bugfixes #16729
Merged
JSON bugfixes #16729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
All of which are JSON-related. I am targeting
main, as these bugs aren't critical, and the JSON reader has gone through large changes onmain, so fixing them there saves the effort of fixing them twice.I've also fixed #16572 in this PR. The issue was caused by DuckDB preventing breadth-first plan evaluation to avoid using more memory than necessary. However, there is no risk of running out of memory when all of the children of a
UNION ALLdon't contain anySinkoperators. By checking if this is the case, we can allow more parallelism forUNION ALL.I have tested that this works with
test/sql/parallelism/intraquery/depth_first_evaluation.test_slowlocally (so this doesn't break the desired behavior when there areSinkoperators), but this test is disabled because it was causing issues in CI.