8000 Call Notify External Repositories from Invoke CI by maiadegraaf · Pull Request #16747 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Call Notify External Repositories from Invoke CI #16747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maiadegraaf
Copy link
Contributor

Adds two workflow calls:

  • if git_ref is empty, runs the vendor script on the odbc main branch
  • otherwise passes git_ref as the duckdb_sha and runs on the corresponding branch on odbc

I've tested on my fork, the script works, cannot confirm that the vendor script is run, will have to see after the merge.

@maiadegraaf maiadegraaf requested a review from carlopi March 20, 2025 09:37
Copy link
Contributor
@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, adding needs is important, the other cosmetical.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft March 20, 2025 10:53
@maiadegraaf
Copy link
Contributor Author

@carlopi Thanks for your suggestions, they've been implemented :)

@maiadegraaf maiadegraaf marked this pull request as ready for review March 20, 2025 10:53
@maiadegraaf maiadegraaf requested a review from carlopi March 20, 2025 10:53
Copy link
Contributor
@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mytherin Mytherin merged commit d451946 into duckdb:main Mar 20, 2025
4 checks passed
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
JSON bugfixes (duckdb/duckdb#16729)
Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747)
shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 15, 2025
JSON bugfixes (duckdb/duckdb#16729)
Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747)
shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 16, 2025
JSON bugfixes (duckdb/duckdb#16729)
Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747)
shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 16, 2025
JSON bugfixes (duckdb/duckdb#16729)
Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747)
shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request May 17, 2025
JSON bugfixes (duckdb/duckdb#16729)
Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747)
shell: make -bail work for more errors (duckdb/duckdb#16594)
@maiadegraaf maiadegraaf deleted the add-notify-external-repo-to-invokeci branch May 28, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0