-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Call Notify External Repositories from Invoke CI #16747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mytherin
merged 2 commits into
duckdb:main
from
maiadegraaf:add-notify-external-repo-to-invokeci
Mar 20, 2025
Merged
Call Notify External Repositories from Invoke CI #16747
Mytherin
merged 2 commits into
duckdb:main
from
maiadegraaf:add-notify-external-repo-to-invokeci
Mar 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
suggested changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor suggestions, adding needs
is important, the other cosmetical.
@carlopi Thanks for your suggestions, they've been implemented :) |
carlopi
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
JSON bugfixes (duckdb/duckdb#16729) Call Notify External Repositories from Invoke CI (duckdb/duckdb#16747) shell: make -bail work for more errors (duckdb/duckdb#16594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two workflow calls:
git_ref
is empty, runs the vendor script on the odbc main branchgit_ref
as theduckdb_sha
and runs on the corresponding branch on odbcI've tested on my fork, the script works, cannot confirm that the vendor script is run, will have to see after the merge.