Merge V1.2 -> Main #16751
Merged
Merge V1.2 -> Main #16751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b#16656) Allows for the use of OrderPreservationRecursive elsewhere (eg. an extension operator that needs to decide its order preservation type)
For some OS + architecture combinations, the bundled static libraries exceed 100MB, which can be inconvenient. This PR adds a gather-libs target that collects the individual libraries (pre-bundling) and puts them in a libs folder. When publishing the existing artifact, it also zips that additional libs folder. Follow-up to duckdb#16654.
This is one out of three PRs to avoid accessing uninitialized memory. This change was necessary to satisfy CRAN's incoming checks. CRAN uses gcc 14.2.0 with compile commands similar to the following: ``` g++ -std=gnu++17 -I"D:/RCompile/recent/R/include" -DNDEBUG -I... -O2 -Wall -mfpmath=sse -msse2 -mstackrealign -c duckdb/ub_src_common_types_row.cpp -o duckdb/ub_src_common_types_row.o ``` I believe they are looking for `-Wuninitialized` and `-Wmaybe-uninitialized` . Would you consider having similar checks as part of the CI/CD pipeline here, perhaps with `-Werror` ?
This is one out of three PRs to avoid accessing uninitialized memory. This change was necessary to satisfy CRAN's incoming checks. CRAN uses gcc 14.2.0 with compile commands similar to the following: ``` g++ -std=gnu++17 -DNDEBUG -I... -O2 -Wall -mfpmath=sse -msse2 -mstackrealign -c duckdb/ub_src_common_types_row.cpp -o duckdb/ub_src_common_types_row.o ``` I believe they are looking for `-Wuninitialized` and `-Wmaybe-uninitialized` . Would you consider having similar checks as part of the CI/CD pipeline here, perhaps with `-Werror` ?
This is one out of three PRs to avoid accessing uninitialized memory. This change was necessary to satisfy CRAN's incoming checks. CRAN uses gcc 14.2.0 with compile commands similar to the following: ``` g++ -std=gnu++17 -DNDEBUG -I... -O2 -Wall -mfpmath=sse -msse2 -mstackrealign -c duckdb/ub_src_common_types_row.cpp -o duckdb/ub_src_common_types_row.o ``` I believe they are looking for `-Wuninitialized` and `-Wmaybe-uninitialized` . Would you consider having similar checks as part of the CI/CD pipeline here, perhaps with `-Werror` ?
Fix: duckdblabs/duckdb-internal#4404 Note that I've only added the tests that yielded new errors. All the hanging errors pass if enough time is given, is just that the generated file from the compresses gzipped file becomes quite big.
* Extend MergeSortTree::SelectNth to return remainders * Use the remainders to handle out of bounds results appropriately. fixes: duckdb#16649 fixes: duckdblabs/duckdb-internal#4430
…ing (duckdb#16688) The loop above defines the following condition: ```cpp while (posOut+32 <= size && posIn+4 <= lenIn) ``` i.e. we break either if we are reaching the end of the output buffer, OR we only have three bytes remaining in the input buffer. We then check if we have three bytes remaining as follows: ```cpp if (posOut+24 <= size) { // handle the possibly 3 last bytes without a loop ``` This is incorrect, it should be the same as the condition above.
…map pushdown (duckdb#16691) Fixes duckdb#16627 These filters were not generated before and hence not handled - now we generate them.
Fixes duckdb#16554 I looked through the history and could not figure out why this was explicitly disabled
avro has been assimilated and will become part of core extensions due to us wanting to make the iceberg extensions depend on it
Apply the window ordering in BindSortedAggregate if the aggregate is order-sensitive but no ordering argument was provided. fixes: duckdb#16652 fixes: duckdblabs/duckdb-internal#4433
Apply the window ordering in BindSortedAggregate if the aggregate is order-sensitive but no ordering argument was provided. fixes: duckdb#16652 fixes: duckdblabs/duckdb-internal#4433
* Extend MergeSortTree::SelectNth to return remainders * Use the remainders to handle out of bounds results appropriately. fixes: duckdb#16649 fixes: duckdblabs/duckdb-internal#4430
…ys adding a semicolon, better have too many than not enough
…l` (duckdb#16723) This PR fixes duckdb#16719 Also added semicolons extra to every line in the `schema.sql`, better have too many than not enough.
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Merge V1.2 -> Main (duckdb/duckdb#16751) update expected results reflecting the changes brought ups with `Fix roundtripping of stringified nested types` PR (duckdb/duckdb#16775) Fix two minor problems with NotifyExternalRepositories / odbc (duckdb/duckdb#16776)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 15, 2025
Merge V1.2 -> Main (duckdb/duckdb#16751) update expected results reflecting the changes brought ups with `Fix roundtripping of stringified nested types` PR (duckdb/duckdb#16775) Fix two minor problems with NotifyExternalRepositories / odbc (duckdb/duckdb#16776)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Merge V1.2 -> Main (duckdb/duckdb#16751) update expected results reflecting the changes brought ups with `Fix roundtripping of stringified nested types` PR (duckdb/duckdb#16775) Fix two minor problems with NotifyExternalRepositories / odbc (duckdb/duckdb#16776)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2025
Merge V1.2 -> Main (duckdb/duckdb#16751) update expected results reflecting the changes brought ups with `Fix roundtripping of stringified nested types` PR (duckdb/duckdb#16775) Fix two minor problems with NotifyExternalRepositories / odbc (duckdb/duckdb#16776)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
May 17, 2025
Merge V1.2 -> Main (duckdb/duckdb#16751) update expected results reflecting the changes brought ups with `Fix roundtripping of stringified nested types` PR (duckdb/duckdb#16775) Fix two minor problems with NotifyExternalRepositories / odbc (duckdb/duckdb#16776)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.