8000 [Dev] Fix `EXPORT DATABASE` missing semicolons in produced `schema.sql` by Tishj · Pull Request #16723 · duckdb/duckdb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Dev] Fix EXPORT DATABASE missing semicolons in produced schema.sql #16723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

[Dev] Fix EXPORT DATABASE missing semicolons in produced schema.sql #16723

merged 1 commit into from
Mar 19, 2025
+2 −1

Conversation

Tishj
Copy link
Contributor
@Tishj Tishj commented Mar 19, 2025

This PR fixes #16719

Also added semicolons extra to every line in the schema.sql, better have too many than not enough.

@Tishj
fixed the specific issue, added a safeguard against this by just alwa…
9c49af8 
…ys adding a semicolon, better have too many than not enough
@Mytherin Mytherin merged commit 09bf1d7 into duckdb:v1.2-histrionicus Mar 19, 2025
48 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Apr 8, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@09bf1d7
e5eeea2 
[Dev] Fix `EXPORT DATABASE` missing semicolons in produced `schema.sql` (duckdb/duckdb#16723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tishj @Mytherin
0