8000 [dashboard] Remove dependency on listing secrets by kvaps · Pull Request #1062 · cozystack/cozystack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[dashboard] Remove dependency on listing secrets #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

[dashboard] Remove dependency on listing secrets #1062

merged 1 commit into from
Jun 16, 2025
+2 −2

Conversation

kvaps
Copy link
Member
@kvaps kvaps commented Jun 16, 2025 •
edited by coderabbitai bot
Loading

This change includes the following commit cozystack/kubeapps@6856b66

Signed-off-by: Andrei Kvapil kvapss@gmail.com

Summary by CodeRabbit

  • Chores
    • Updated the version of a core dependency used in the dashboard and related services to a newer commit. No user-facing changes.

@kvaps kvaps requested review from lllamnyp and klinch0 as code owners June 16, 2025 16:04
@kvaps kvaps added the backport Should change be backported on previus release label Jun 16, 2025
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 16, 2025 •
edited
Loading

Warning

Rate limit exceeded

@kvaps has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 667d1d8 and 9dc5d62.

📒 Files selected for processing (2)
  • packages/system/dashboard/images/dashboard/Dockerfile (1 hunks)
  • packages/system/dashboard/images/kubeapps-apis/Dockerfile (1 hunks)

Walkthrough

The Dockerfiles for both the dashboard and kubeapps-apis images were updated to use a new commit reference for downloading the source code during the build process. No other modifications to the build steps, dependencies, or logic were made.

Changes

File(s) Change Summary
.../dashboard/images/dashboard/Dockerfile,
.../dashboard/images/kubeapps-apis/Dockerfile		 Updated the COMMIT_REF build argument to a new commit hash for source retrieval.

Possibly related PRs

Suggested labels

size:M, lgtm

Suggested reviewers

  • klinch0

Poem

In Docker’s warren, hashes hop anew,
Fresh commit carrots for images to chew.
With every build, the garden grows,
New code beneath the dashboard flows.
A rabbit’s joy, a simple feat—
Updated hashes, oh so neat! 🥕

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps kvaps removed the backport Should change be backported on previus release label Jun 16, 2025
@NickVolynkin NickVolynkin mentioned this pull request Jun 16, 2025
Merged
@kvaps kvaps changed the title [dashboard] Remove dependency on linsting secrets [dashboard] Remove dependency on listing secrets Jun 16, 2025
@kvaps
[dashboard] Remove dependency on listing secrets
9dc5d62 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps force-pushed the dashboard-no-secrets branch from 667d1d8 to 9dc5d62 Compare June 16, 2025 18:32
@kvaps kvaps merged commit cf983a8 into main Jun 16, 2025
7 checks passed
@kvaps kvaps deleted the dashboard-no-secrets branch June 16, 2025 18:48
kvaps added a commit that referenced this pull request Jun 16, 2025
@kvaps
[dashboard] Remove dependency on listing secrets (#1062)
d3266a8 
This change includes the following commit
cozystack/kubeapps@6856b66

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **Chores**
- Updated the version of a core dependency used in the dashboard and
related services to a newer commit. No user-facing changes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lllamnyp lllamnyp Awaiting requested review from lllamnyp lllamnyp is a code owner

@klinch0 klinch0 Awaiting requested review from klinch0 klinch0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kvaps
0