Update cozystack-dashboard to show workload status #562
Conversation
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (10)
packages/system/dashboard/images/dashboard/apple-touch-icon.pngis excluded by!**/*.pngpackages/system/dashboard/images/dashboard/favicon-16x16.pngis excluded by!**/*.pngpackages/system/dashboard/images/dashboard/favicon-32x32.pngis excluded by!**/*.pngpackages/system/dashboard/images/dashboard/favicon.icois excluded by!**/*.icopackages/system/dashboard/images/dashboard/mstile-144x144.pngis excluded by!**/*.pngpackages/system/dashboard/images/dashboard/mstile-150x150.pngis excluded by!**/*.pngpackages/system/dashboard/images/dashboard/mstile-310x150.pngis excluded by!**/*.pngpackages/system/dashboard/images/dashboard/mstile-310x310.pngis excluded by!**/*.pngpackages/system/dashboard/images/dashboard/mstile-70x70.pngis excluded by!**/*.pngpackages/system/dashboard/images/dashboard/safari-pinned-tab.svgis excluded by!**/*.svg
📒 Files selected for processing (7)
packages/system/dashboard/charts/kubeapps/templates/dashboard/configmap.yaml(1 hunks)packages/system/dashboard/images/dashboard/Dockerfile(1 hunks)packages/system/dashboard/images/dashboard/documentation.diff(0 hunks)packages/system/dashboard/images/dashboard/release-url.diff(0 hunks)packages/system/dashboard/images/dashboard/remove-manage-repositories.diff(0 hunks)packages/system/dashboard/images/kubeapps-apis/Dockerfile(1 hunks)packages/system/dashboard/values.yaml(1 hunks)
💤 Files with no reviewable changes (3)
- packages/system/dashboard/images/dashboard/documentation.diff
- packages/system/dashboard/images/dashboard/remove-manage-repositories.diff
- packages/system/dashboard/images/dashboard/release-url.diff
🔇 Additional comments (2)
packages/system/dashboard/images/dashboard/Dockerfile (1)
4-5: Verify the commit reference and source repository.The source code is being fetched from a fork (aenix-io/kubeapps) using a specific commit hash. This approach needs verification:
- The commit hash should be documented for traceability
- The fork's relationship with upstream should be clarified
✅ Verification successful
Source and commit reference verified successfully
The setup is legitimate:
- The repository is a proper fork of vmware-tanzu/kubeapps
- The commit (215c323) exists in both the fork and upstream
- The commit message "Personalize for Cozystack" clearly indicates its customization purpose
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the commit exists and its relationship with upstream gh api repos/aenix-io/kubeapps/commits/${COMMIT_REF} --jq '.commit.message' # Check if this commit exists in upstream gh api repos/vmware-tanzu/kubeapps/commits/${COMMIT_REF} --jq '.commit.message' || echo "Commit not found in upstream"Length of output: 546
Script:
#!/bin/bash # Check if the fork exists and get its details gh api repos/aenix-io/kubeapps --jq '.fork, .parent.full_name' || echo "Fork not found" # Verify the commit exists in the fork gh api repos/aenix-io/kubeapps/commits/215c323b0754c8f7328819df9a253e0e507eccb4 --jq '.commit.message' || echo "Commit not found in fork" # Check if this commit exists in upstream gh api repos/vmware-tanzu/kubeapps/commits/215c323b0754c8f7328819df9a253e0e507eccb4 --jq '.commit.message' || echo "Commit not found in upstream"Length of output: 353
packages/system/dashboard/images/kubeapps-apis/Dockerfile (1)
7-7: LGTM! Consistent commit reference with dashboard.Good practice using the same commit reference (215c323b) across both dashboard and APIs components, ensuring version compatibility.
| @@ -76,7 +76,7 @@ data: | |||
| "kubeappsNamespace": {{ .Release.Namespace | quote }}, | |||
| "helmGlobalNamespace": {{ include "kubeapps.helmGlobalPackagingNamespace" . | quote }}, | |||
| "carvelGlobalNamespace": {{ .Values.kubeappsapis.pluginConfig.kappController.packages.v1alpha1.globalPackagingNamespace | quote }}, | |||
| "appVersion": "v0.21.1", | |||
| "appVersion": "latest", | |||
There was a problem hiding this comment.
Reconsider using "latest" as appVersion in production.
Using "latest" version can lead to:
- Inconsistent deployments across environments
- Difficulty in tracking and debugging issues
- Potential breaking changes without explicit opt-in
Consider using a specific version or the actual commit hash for better traceability.
| tag: latest | ||
| digest: "sha256:cdf9d93a9733ce6f59d467a03a34bb66177eb4b42715fcf81f84705b150d9dad" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Review the image tagging strategy.
While using a specific digest provides immutability, the "latest" tag practice has drawbacks:
- Makes rollbacks more difficult
- Complicates audit trails
- May cause confusion when digest doesn't match what's expected from "latest"
Consider using semantic versions or commit-based tags instead.
| tag: latest | ||
| digest: "sha256:4842d2e0c4067b73414f815419ae8c83ddb56c287cc45e1648cb700da3842770" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Maintain consistent versioning strategy across components.
The same concerns about using "latest" tag apply here. Consider adopting a consistent versioning strategy that:
- Uses semantic versions or commit-based tags
- Maintains the digest for immutability
- Facilitates easier tracking and rollbacks
Summary by CodeRabbit
Release Notes
New Features
Changes
Removed Features