fix(e2e): remove bls from e2e generator (backport #3721) #3723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #3720 With this change, the `e2e` generator no longer generates manifests with bls as key type, so bls is no longer tested in the nightlies. This is temporary, to be reverted also as part of #3720 in a future PR Manual nightly run: [here](https://github.com/cometbft/cometbft/actions/runs/10418554752/job/28854915428) --- #### PR checklist - ~[ ] Tests written/updated~ - ~[ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ (cherry picked from commit 79602f1) # Conflicts: # test/e2e/generator/generate.go
|
Cherry-pick of 79602f1 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@sergio-mena do we really need to backport this? I would assume no since #3513 wasn’t backported to v1.x |
|
@andynog you're very right. For some reason I thought we have backported it, my bad. Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3720
With this change, the
e2egenerator no longer generates manifests with bls as key type, so bls is no longer tested in the nightlies.This is temporary, to be reverted also as part of #3720 in a future PR
Manual nightly run: here
PR checklist
[ ] Tests written/updated[ ] Changelog entry added in.changelog(we use unclog to manage our changelog)[ ] Updated relevant documentation (docs/orspec/) and code commentsThis is an automatic backport of pull request #3721 done by [Mergify](https://mergify.com).