BLS still has some deterministic failures in the e2e nighlies
#3720
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 16, 2024
Part of #3720 With this change, the `e2e` generator no longer generates manifests with bls as key type, so bls is no longer tested in the nightlies. This is temporary, to be reverted also as part of #3720 in a future PR Manual nightly run: [here](https://github.com/cometbft/cometbft/actions/runs/10418554752/job/28854915428) --- #### PR checklist - ~[ ] Tests written/updated~ - ~[ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~
mergify bot
pushed a commit
that referenced
this issue
Aug 16, 2024
Part of #3720 With this change, the `e2e` generator no longer generates manifests with bls as key type, so bls is no longer tested in the nightlies. This is temporary, to be reverted also as part of #3720 in a future PR Manual nightly run: [here](https://github.com/cometbft/cometbft/actions/runs/10418554752/job/28854915428) --- #### PR checklist - ~[ ] Tests written/updated~ - ~[ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ (cherry picked from commit 79602f1) # Conflicts: # test/e2e/generator/generate.go
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 16, 2024
Part of #3720 `e2e` tests _require_ a method that generates a private key deterministically (from a secret). Without such method, is it not possible for the "tests" step of the `e2e` runner to recreate the node structure as it exists within the runner itself. Manual nightly runs: - [1st try](https://github.com/cometbft/cometbft/actions/runs/10424046666) - [2nd try](https://github.com/cometbft/cometbft/actions/runs/10424939531), after 53321d4 --- #### PR checklist - ~[ ] Tests written/updated~ - ~[ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
In order to prevent that acting as noise, let us:
The text was updated successfully, but these errors were encountered: