8000 system/ui: improve button press behavior by deanlee · Pull Request #35309 · commaai/openpilot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

system/ui: improve button press behavior #35309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

system/ui: improve button press behavior #35309

merged 1 commit into from
May 21, 2025

Conversation

deanlee
Copy link
Contributor
@deanlee deanlee commented May 21, 2025

Improve button press behavior to match Qt:

  1. Pressed color shows only when the mouse is over the button
  2. Color returns to normal when the mouse leaves
  3. Pressed color resumes if the mouse returns while still held
  4. Other buttons are unaffected

resolve:

but you still get the highlight style if you touch then drag your finger onto a button.

@deanlee deanlee mentioned this pull request May 21, 2025
Merged
@github-actions github-actions bot added the ui label May 21, 2025
@incognitojam incognitojam merged commit 7ea8277 into commaai:master May 21, 2025
16 checks passed
@deanlee deanlee deleted the pyui_button_improve_press_behavior branch May 21, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @incognitojam
0