8000 system/ui: improve button click logic for proper press-release interaction by deanlee · Pull Request #35289 · commaai/openpilot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

system/ui: improve button click logic for proper press-release interaction #35289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

deanlee
Copy link
Contributor
@deanlee deanlee commented May 20, 2025
  • Added proper tracking of which button was initially pressed
  • Modified click detection logic to verify press-release continuity
  • Added cleanup for button press state when releasing outside button

@deanlee deanlee force-pushed the pyui_iprove_button_click_logic branch from 2ed77fa to 2096975 Compare May 20, 2025 05:17
@incognitojam incognitojam merged commit f00bead into commaai:master May 20, 2025
16 checks passed
@deanlee deanlee deleted the pyui_iprove_button_click_logic branch May 20, 2025 09:31
@adeebshihadeh
Copy link
Contributor

So the actual click seems fixed now, but you still get the highlight style if you touch then drag your finger onto a button.

@deanlee
Copy link
Contributor Author
deanlee commented May 21, 2025

So the actual click seems fixed now, but you still get the highlight style if you touch then drag your finger onto a button.

resolved: #35309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0