<
8000
/div>
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[collectd 6] Cirrus CI / GitHub Workers - sync config with main branch #4084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create build.yml
* [githubactions] Use collectd-ci container to run tests Uses containers for collectd provided by collectd/ci-docker [1] Repeats what travis was using for building collectd * checks out branch * installs dependencies (already in containers) * runs the script commands from travis (pkg-config, confgure, make) [1] https://github.com/collectd/ci-docker [githubactions] Add config flags to builds * [githubactions] Add a job for experimental OSes * [GHA] update actions for new distro containers in collectd/ci-docker * Mark ``make check`` as optional for now it is not passing reliably, and is being marked as optional until it is Co-authored-by: BarometerExperimental <barometer-experimental@container>
…cies (collectd#3975) * [ci][gha] Replace trusy with Bionic and Focal Ubuntu 14.04 (Trusty) is out of standard support [1]. ``make check`` fails for test_capabilities, as noted in [2]. [3] indicates that the cause is glibc, but that updates are not expected to the version in trusty. This PR replaces trusty with Ubuntu 18.04 (Bionic) and 20.04 (Focal). [1] https://wiki.ubuntu.com/Releases [2] collectd#3936 [3] collectd#3927 (comment) * [ci][cirrus] Make Valgrind error on defininte memory leaks only Valgrind gives errors when it find possible leaks; update the options to only error on definite leaks. This is done using the VALGRIND_OPTS env var, which is used by valgrind when it is invoked. * [ci][gha] Make Valgrind error on defininte memory leaks only Valgrind gives errors when it find possible leaks; update the options to only error on definite leaks. This is done using the VALGRIND_OPTS env var, which is used by valgrind when it is invoked.
* [ci][gha] Add a test log when the tests fail * [ci][cirrus] Update CI to provide test logs on failure Co-authored-by: Matthias Runge <mrunge@redhat.com>
) * [ci][gha] Rename tasks * [ci][gha] Update and use MAKEFLAGS * [ci][gha] Remove continue-on-error from ``make distcheck`` tasks Installation of bzip2 and make distcheck were failing on el8. This was resolved by updating it to use CentOS Stream 8 in [1] [1] collectd/ci-docker#55
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
It had been reached EOL at November 30th, 2020. There is no security updates available anymore. ref. https://wiki.centos.org/About/Product Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
faa1224 to
6b9686d
Compare
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
5f1ba8c to
542f40e
Compare
|
I've now added enough |
|
Thank you! While there are undeniable CI failures, I still think this is a good step forward. I am inclined to merge it anyways. |
mrunge
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we've found some differences in the way the CI behaves between the
mainand thecollect-6.0branches in #4077.This PR cherry-picks all changes to
.cirrus.ymland.github/workflows/build.ymlfrommainon top ofcollectd-6.0.Changes introduced here that were not in
main/collectd-6.0are:on_failure:instead of|| cat … || falsein the.cirrus.ymlto print a log on failure. This matches the what 1b040d7 already did in thecollectd-6.0branch and is imho prettier.collectd-6.0branch in the GitHub action config instead ofmain.My only experience with these CI runners is them flagging my pull requests as bad, so feel free to comment if something looks wrong.
The GitHub worker config will likely need to be extended to disable plugins that are not yet buildable.
ChangeLog: CI: Update collectd-6.0 branch to match main