[ci][gha] Miscellaneous improvements and sync with cirrus #3976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Installation of bzip2 and make distcheck were failing on el8. This was resolved by updating it to use CentOS Stream 8 in [1] [1] collectd/ci-docker#55
mrunge
reviewed
Feb 15, 2022
| - name: install bzip2 | ||
| continue-on-error: true | ||
| run: | | ||
| - name: Install bzip2 |
There was a problem hiding this comment.
what about installing bzip2 in the used containers?
There was a problem hiding this comment.
That's a possibility. It'll take a while to update all the containers though, the changes are trivial, but the process is tedious)
But it should save a little bit of time in the CI runs.
I can update this PR to remove these, and then it'll become dependant on the new container changes.
1c736e9 to
69bd5bf
Compare
|
FYI, I'll remove the install bzip stage, and add it to the containers. |
carlospeon
pushed a commit
to carlospeon/collectd
that referenced
this pull request
Oct 17, 2022
) * [ci][gha] Rename tasks * [ci][gha] Update and use MAKEFLAGS * [ci][gha] Remove continue-on-error from ``make distcheck`` tasks Installation of bzip2 and make distcheck were failing on el8. This was resolved by updating it to use CentOS Stream 8 in [1] [1] collectd/ci-docker#55
hnez
pushed a commit
to hnez/collectd
that referenced
this pull request
Jan 30, 2023
) * [ci][gha] Rename tasks * [ci][gha] Update and use MAKEFLAGS * [ci][gha] Remove continue-on-error from ``make distcheck`` tasks Installation of bzip2 and make distcheck were failing on el8. This was resolved by updating it to use CentOS Stream 8 in [1] [1] collectd/ci-docker#55
hnez
pushed a commit
to hnez/collectd
that referenced
this pull request
Jan 30, 2023
) * [ci][gha] Rename tasks * [ci][gha] Update and use MAKEFLAGS * [ci][gha] Remove continue-on-error from ``make distcheck`` tasks Installation of bzip2 and make distcheck were failing on el8. This was resolved by updating it to use CentOS Stream 8 in [1] [1] collectd/ci-docker#55
mrunge
pushed a commit
that referenced
this pull request
Feb 1, 2023
* [ci][gha] Rename tasks * [ci][gha] Update and use MAKEFLAGS * [ci][gha] Remove continue-on-error from ``make distcheck`` tasks Installation of bzip2 and make distcheck were failing on el8. This was resolved by updating it to use CentOS Stream 8 in [1] [1] collectd/ci-docker#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.