8000 Redefine glog's branch prediction macros by ahojnnes · Pull Request #3443 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Redefine glog's branch prediction macros #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

Redefine glog's branch prediction macros #3443

merged 2 commits into from
Jul 2, 2025

Conversation

ahojnnes
Copy link
Contributor
@ahojnnes ahojnnes commented Jul 1, 2025

Older glog versions do not have these macros defined, which leads to a compilation error.

@ahojnnes ahojnnes requested review from sarlinpe and B1ueber2y July 1, 2025 10:45
B1ueber2y
B1ueber2y approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor
@B1ueber2y B1ueber2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Does it make sense to put these macros into a separate file and include it in util/logging.h?

@sarlinpe
Copy link
Member
sarlinpe commented Jul 1, 2025

Yes I would also move them to logging_macros.h or so, such that we can use a different license header with clearer marking of which code it applies to.

@ahojnnes
Copy link
Contributor Author
ahojnnes commented Jul 2, 2025

Thanks, done.

@ahojnnes ahojnnes enabled auto-merge (squash) July 2, 2025 07:14
sarlinpe
sarlinpe approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member
@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ahojnnes ahojnnes merged commit 45391e1 into main Jul 2, 2025
14 checks passed
@ahojnnes ahojnnes deleted the user/jsch/glog-branch-predict branch July 2, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

@B1ueber2y B1ueber2y B1ueber2y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahojnnes @sarlinpe @B1ueber2y
0