8000 script for modifying fused results by SBCV · Pull Request #984 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

script for modifying fused results #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2020
Merged

script for modifying fused results #984

merged 1 commit into from
Sep 21, 2020

Conversation

SBCV
Copy link
Contributor
@SBCV SBCV commented Sep 18, 2020

No description provided.

@SBCV SBCV mentioned this pull request Sep 18, 2020
Open
ahojnnes
ahojnnes reviewed Sep 20, 2020
View reviewed changes
ahojnnes
ahojnnes reviewed Sep 20, 2020
View reviewed changes
ahojnnes
ahojnnes reviewed Sep 20, 2020
View reviewed changes
@ahojnnes
Copy link
Contributor

Looks great, thanks. Left some minor comments for you.

@SBCV
Copy link
Contributor Author
SBCV commented Sep 20, 2020

Changed the PR according to your comments and updated the PR accordingly. I guess the two "unused" comments referred both to "import struct"?

@ahojnnes
Copy link
Contributor

Pandas seems like a heavy dependency just for enabling structured numpy arrays. The same should be possible with numpy out of the box?

@SBCV
Copy link
Contributor Author
SBCV commented Sep 21, 2020

I leveraged the pandas package here, because it is internally used by the pyntcloud package (and will be automatically installed with pip install pyntcloud).

I've also considered other libraries than pyntcloud.

For example, in the past I've used plyfile, which has no other dependencies. However, the interface of plyfile is really convoluted and a lot of custom code is required for writing points from and to plyfiles. See this this file for example. In addition, I've read that pyntcloud is three times faster.

I also considered Open3D for reading/writing ply files. However, Open3D does not support to configure the types in the generated output file (32 bit float vs 64 bit float). Thus, with Open3D it is not possible to compare the results, i.e.

    assert filecmp.cmp(path_to_fused_ply_input, path_to_fused_ply_output)
    assert filecmp.cmp(path_to_fused_ply_vis_input, path_to_fused_ply_vis_output)

Thus, I think that the pyntcloud package is a valid choice - and therefore the usage of pandas not too bad. What do you think?

@ahojnnes
Copy link
Contributor

Thanks for the explanations, makes sense to me. Merging and thanks for the contribution.

@ahojnnes ahojnnes merged commit af40e1a into colmap:dev Sep 21, 2020
lucasthahn pushed a commit to tne-ai/colmap that referenced this pull request Aug 17, 2022
@SBCV @lucasthahn
script for modifying fused results (colmap#984)
4b5b25b
@SBCV SBCV deleted the read_write_fused_vis_ply branch January 6, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes ahojnnes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBCV @ahojnnes
0