8000 pep257 cleanup of cookiecutter.exceptions by minchinweb · Pull Request #1237 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pep257 cleanup of cookiecutter.exceptions #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 22, 2019
Merged

pep257 cleanup of cookiecutter.exceptions #1237

merged 10 commits into from
Dec 22, 2019

Conversation

minchinweb
Copy link
Contributor

cf #742

@codecov
Copy link
codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #1237 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1237   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          18      18           
  Lines         784     785    +1     
======================================
+ Hits          784     785    +1
Impacted Files Coverage Δ
cookiecutter/exceptions.py 100% <100%> (ø) ⬆️
cookiecutter/__init__.py 100% <100%> (ø) ⬆️
cookiecutter/cli.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673f773...e1480bf. Read the comment docs.

arkarn04 and others added 2 commits October 16, 2019 00:23
@arkarn04
Update README.md
4c7351a 
My contribution to Open Source.
@insspb
Dots fixing in read me
7232252 
Update README.md
insspb
insspb suggested changes Oct 23, 2019
View reviewed changes
Copy link
Member
@insspb insspb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minchinweb thank you for commit, please fix typos.
Looks good on other things.
but as far as I remember project files, Can you ensure that all exceptions are in use?

@insspb insspb added the waiting-for-contributor Waiting for answer from original contributor. label Oct 23, 2019
@minchinweb
fix spelling
d1d9420 
Exemption --> Exception
@minchinweb
Copy link
Contributor Author

@insspb Typo fixed!

UnknownTemplateDirException and MissingProjectDir aren't used locally, but I hesitate to remove them in case downstream projects make use of them. Their remove should at least be mentioned in the changelog...

Also, #1112 (from a year ago) covers much of this same ground.

@insspb insspb added the 1.7.0 label Dec 22, 2019
@insspb insspb merged commit 7ea7b79 into cookiecutter:master Dec 22, 2019
insspb added a commit that referenced this pull request Dec 22, 2019
@insspb
History and authors update
1ac5a42 
* History and authors update

* Added author of #1237

* Added author of #1234

* Added author of #1236, #1262
@minchinweb minchinweb deleted the pep257-wm branch December 25, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insspb insspb insspb requested changes

532F
Assignees
No one assigned
Labels
waiting-for-contributor Waiting for answer from original contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@minchinweb @insspb @arkarn04 @sobolevn @mattstibbs
0