8000 Ran pep257 for replay.py by kishan3 · Pull Request #1234 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ran pep257 for replay.py #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2019
Merged

Ran pep257 for replay.py #1234

merged 1 commit into from
Dec 22, 2019

Conversation

kishan3
Copy link
@kishan3 kishan3 commented Oct 1, 2019

Working on #742, added pep257 recommendations on replay.py file.

Ran pep257 for replay.py
3f89f7e 
Working on cookiecutter#742, added pep257 recommendations on replay.py file.
@codecov
Copy link
codecov bot commented Oct 1, 2019 •
edited
Loading

Codecov Report

Merging #1234 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1234   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          18      18           
  Lines         784     785    +1     
======================================
+ Hits          784     785    +1
Impacted Files Coverage Δ
cookiecutter/replay.py 100% <ø> (ø) ⬆️
cookiecutter/cli.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673f773...3f89f7e. Read the comment docs.

This was referenced Oct 8, 2019
Closed
Closed
@firejava
Copy link
firejava commented Oct 8, 2019

Looks good

@kishan3
Copy link
Author
kishan3 commented Oct 9, 2019

Thanks, @firejava Can you merge it?

@luzfcb luzfcb self-requested a review October 9, 2019 22:01
@insspb insspb self-requested a review October 23, 2019 21:30
@insspb insspb added needs-merge needs-review PR Only: This PR require review from other developer labels Oct 23, 2019
@insspb insspb added this to the 1.7.0 milestone Oct 23, 2019
@insspb insspb added the 1.7.0 label Dec 22, 2019
@insspb insspb removed this from the 1.7.0 milestone Dec 22, 2019
@insspb insspb merged commit e5d5c1d into cookiecutter:master Dec 22, 2019
insspb added a commit that referenced this pull request Dec 22, 2019
@insspb
History and authors update
1ac5a42 
* History and authors update

* Added author of #1237

* Added author of #1234

* Added author of #1236, #1262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insspb insspb insspb approved these changes

@luzfcb luzfcb Awaiting requested review from luzfcb

Assignees
No one assigned
Labels
needs-review PR Only: This PR require review from other developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kishan3 @firejava @insspb
0