-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add export command to all items #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cmd/system.go
Outdated
} | ||
|
||
for _, itemName := range itemNames { | ||
distro, err := Client.GetSystem(itemName, false, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be system
, not distro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable is still called distro
60df591
to
1c81390
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, you just forgot to change one variable name. If that is fixed we can merge
cmd/system.go
Outdated
} | ||
|
||
for _, itemName := range itemNames { | ||
distro, err := Client.GetSystem(itemName, false, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable is still called distro
1c81390
to
88abf27
Compare
This adds functionality to allow the exporting of Cobbler objects as JSON or YAML.
Example usage:
This PR needs cobbler/cobblerclient#78 merged and the client version 0.5.8, which contains the merged PR.