8000 Add export command to all items by SchoolGuy · Pull Request #70 · cobbler/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add export command to all items #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

SchoolGuy
Copy link
Member

This adds functionality to allow the exporting of Cobbler objects as JSON or YAML.

Example usage:

cobbler interface export --interface-name="default" --format yaml

This PR needs cobbler/cobblerclient#78 merged and the client version 0.5.8, which contains the merged PR.

@SchoolGuy SchoolGuy added this to the V0.0.1 milestone Mar 11, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in Golang CLI Mar 11, 2025
cmd/system.go Outdated
}

for _, itemName := range itemNames {
distro, err := Client.GetSystem(itemName, false, false)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be system, not distro

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is still called distro

@SchoolGuy SchoolGuy force-pushed the feature/export-json-yaml branch from 60df591 to 1c81390 Compare March 27, 2025 08:22
Copy link
@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, you just forgot to change one variable name. If that is fixed we can merge

cmd/system.go Outdated
}

for _, itemName := range itemNames {
distro, err := Client.GetSystem(itemName, false, false)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is still called distro

@SchoolGuy SchoolGuy force-pushed the feature/export-json-yaml branch from 1c81390 to 88abf27 Compare March 27, 2025 11:29
@SchoolGuy SchoolGuy merged commit 76b0a3a into main Mar 27, 2025
16 of 18 checks passed
@SchoolGuy SchoolGuy deleted the feature/export-json-yaml branch March 27, 2025 11:57
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in Golang CLI Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
0