8000 Add JSON and YAML tags by SchoolGuy · Pull Request #78 · cobbler/cobblerclient · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add JSON and YAML tags #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

Add JSON and YAML tags #78

merged 2 commits into from
Mar 14, 2025

Conversation

SchoolGuy
Copy link
Member

This is to allow clients to export the data in a well-structured manner.

@codacy-production Codacy Production
Copy link
codacy-production bot commented Feb 19, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.21% (target: -1.00%) ❌ 35.71% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c7438d5) 3312 1971 59.51%
Head commit (1867b97) 3339 (+27) 1980 (+9) 59.30% (-0.21%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#78) 28 10 35.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@SchoolGuy
Add JSON and YAML tags
b5bec30 
This is to allow clients to export the data in a well-structured manner.
@SchoolGuy SchoolGuy moved this to Pull Requests in Golang Client Mar 11, 2025
@SchoolGuy SchoolGuy marked this pull request as ready for review March 11, 2025 10:23
@SchoolGuy
Copy link
Member Author

I will open a PR for the CLI later today to showcase the usage of this functionality.

@SchoolGuy SchoolGuy mentioned this pull request Mar 11, 2025
Merged
tiltingpenguin
tiltingpenguin approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor
@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy merged commit 842edce into main Mar 14, 2025
18 of 19 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in Golang Client Mar 14, 2025
@SchoolGuy SchoolGuy deleted the feature/json-yaml branch March 27, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiltingpenguin tiltingpenguin tiltingpenguin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Golang Client
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchoolGuy @tiltingpenguin
0