10000 Fix exported event fields by SchoolGuy · Pull Request #74 · cobbler/cobblerclient · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix exported event fields #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix exported event fields #74

merged 2 commits into from
Oct 29, 2024

Conversation

SchoolGuy
Copy link
Member

Fixes #61
Fixes #73

@SchoolGuy
Event: Make fields public
914fa31 
Signed-off-by: Enno Gotthold <matrixfueller@gmail.com>
@SchoolGuy
Client: Handle deferred error during HTTP body closing
746c09a 
Signed-off-by: Enno Gotthold <matrixfueller@gmail.com>
@SchoolGuy SchoolGuy added this to the 0.5.4 milestone Oct 29, 2024
@SchoolGuy SchoolGuy requested a review from a team October 29, 2024 09:12
@codacy-production Codacy Production
Copy link
codacy-production bot commented Oct 29, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.02% (target: -1.00%) ✅ 84.62% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6ede036) 3259 1937 59.44%
Head commit (746c09a) 3262 (+3) 1938 (+1) 59.41% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#74) 13 11 84.62%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

tiltingpenguin
tiltingpenguin approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor
@tiltingpenguin tiltingpenguin left a comment
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy merged commit 1d19219 into main Oct 29, 2024
21 checks passed
@SchoolGuy SchoolGuy deleted the fix/exported-event-fields branch October 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiltingpenguin tiltingpenguin tiltingpenguin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Golang Client
Status: Done
Milestone
0.5.4
Development

Successfully merging this pull request may close these issues.

Unexported attributes in CobblerEvent Handle error in deferred body close
2 participants
@SchoolGuy @tiltingpenguin
0