Handle error in deferred body close

Is your feature request related to a problem?

As a developer
I want to react to all thrown errors
so that I can do the proper cleanup in case something goes wrong.

Provide a detailed description of the proposed feature

The error that may or may not be produced should be fixed in a way that we return a slice of errors that contains both the error from the function body and the deferred function.

cobblerclient/cobblerclient.go

Lines 81 to 91 in 729746b

    
           r := fmt.Sprintf("%s\n", string(reqBody)) 
        
           res, err := c.httpClient.Post(c.config.URL, bodyTypeXML, bytes.NewReader([]byte(r))) 
        
           if err != nil { 
        
           	return nil, err 
        
           } 
        
           defer res.Body.Close() 
        
           body, err := ioutil.ReadAll(res.Body) 
        
           if err != nil { 
        
           	return nil, err 
        
           }

Alternatives you've considered

None

Additional information

Blog article describing the whys and hows: https://trstringer.com/golang-deferred-function-error-handling/

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Is your feature request related to a problem?

Provide a detailed description of the proposed feature

Alternatives you've considered

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	r := fmt.Sprintf("%s\n", string(reqBody))
	res, err := c.httpClient.Post(c.config.URL, bodyTypeXML, bytes.NewReader([]byte(r)))
	if err != nil {
	return nil, err
	}

	defer res.Body.Close()
	body, err := ioutil.ReadAll(res.Body)
	if err != nil {
	return nil, err
	}

Uh oh!

Description

Is your feature request related to a problem?

Provide a detailed description of the proposed feature

Alternatives you've considered

Additional information

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions