8000 Add indicators for the Boot Menus by SchoolGuy · Pull Request #2694 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add indicators for the Boot Menus #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Add indicators for the Boot Menus #2694

merged 1 commit into from
Jul 2, 2021

Conversation

SchoolGuy
Copy link
Member

This PR fixes #2693

This PR tries to address the missing indicators for menu entries which have no indicator that they are actually not a bootable entry but a placeholder for a group of subentries.

@SchoolGuy SchoolGuy added this to the v3.3.0 milestone Jun 29, 2021
@SchoolGuy SchoolGuy requested a review from a team June 29, 2021 17:45
@SchoolGuy SchoolGuy changed the title WIP: Add indicators for the Boot Menus Add indicators for the Boot Menus Jul 1, 2021
Copy link
Contributor
@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link
codecov bot commented Jul 1, 2021

Codecov Report

Merging #2694 (a6bcf63) into master (bb089ad) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2694   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files          86       86           
  Lines       13376    13375    -1     
=======================================
  Hits         5281     5281           
+ Misses       8095     8094    -1     
Impacted Files Coverage Δ
cobbler/tftpgen.py 25.89% <60.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb089ad...a6bcf63. Read the comment docs.

@SchoolGuy SchoolGuy assigned SchoolGuy and unassigned nodeg Jul 2, 2021
@SchoolGuy SchoolGuy merged commit b68e37b into master Jul 2, 2021
@SchoolGuy SchoolGuy deleted the fix/gh-2693 branch July 2, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add indicators for grub distro level menus
4 participants
0