8000 Add indicators for grub distro level menus · Issue #2693 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add indicators for grub distro level menus #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SchoolGuy opened this issue Jun 29, 2021 · 9 comments · Fixed by #2694
Closed

Add indicators for grub distro level menus #2693

SchoolGuy opened this issue Jun 29, 2021 · 9 comments · Fixed by #2694
Assignees
@SchoolGuy
Labels
3.1.2 Release 3.1.2 enhancement New feature or request
Milestone
v3.3.0

Comments

@SchoolGuy
Copy link
Member

Is your feature request related to a problem?

This issue is related to #2217

Currently Grub does not indicate that the menu structure contains submenus. Thus we desire that because not everyone knows that we are using submenus now.

Provide a detailed description of the proposed feature

An indicator in the menu which shows that this is not a boot entry.

Alternatives you've considered

  • Letting users discover that for themselves: Well not user friendly
  • Reverting the change: Not good as well since this can cause a lot of overhead in the boot menu.

Additional information

Internal Bug for SUSE Employees: https://github.com/SUSE/spacewalk/issues/15241
@SchoolGuy SchoolGuy added the enhancement New feature or request label Jun 29, 2021
@SchoolGuy SchoolGuy added this to the v3.3.0 milestone Jun 29, 2021
@SchoolGuy SchoolGuy self-assigned this Jun 29, 2021
@SchoolGuy
Copy link
Member Author
SchoolGuy commented Jun 29, 2021 •
edited
Loading

This was refactored with #2575 so sadly the easy way we had then doesn't work now. I will investigate deeper.

@SchoolGuy SchoolGuy added the 3.1.2 Release 3.1.2 label Jun 29, 2021
@SchoolGuy
Copy link
Member Author

This feature request was raised against Cobbler version 3.1.2 since that is was SUMA uses atm. Since the refactoring by @tpw56j was done, I need to reproduce that on master now.

@tpw56j do you have an idea how to add an indicator. I saw your code and was wondering where the most top level menu is generated for all loaders? In make_pxe_menu maybe but I am not sure right now.

@SchoolGuy SchoolGuy mentioned this issue Jun 29, 2021
Merged
@SchoolGuy
Copy link
Member Author

As written in #2684 I found that the children list has invalid entries and thus i need to dive deeper there first.

@SchoolGuy SchoolGuy mentioned this issue Jun 29, 2021
Merged
@tpw56j
Copy link
Contributor
tpw56j commented Jun 29, 2021

@SchoolGuy I will try to remember how the menu is formed, and maybe I will have ideas.

@SchoolGuy
Copy link
Member Author

@tpw56j If not, I will dive into the code deep myself, please just give me ping in any of both cases. :)

@tpw56j
Copy link
Contributor
tpw56j commented Jun 29, 2021

@SchoolGuy I'm very busy right now and will only be able to do this at the end of the week.:(

@SchoolGuy
Copy link
Member Author

@tpw56j That is totally fine. Don't feel bad about it. If you look at the end of the week and update if you took a look or not that is enough. If it is closed by then you just know that I now understand your code... ;)

@tpw56j
Copy link
Contributor
tpw56j commented Jun 29, 2021

@SchoolGuy Maybe this problem can be solved by changing the submenu templates?

For example by adding the '>' symbol in front of $menu_name to cobbler/templates/boot_loader_conf/grub_submenu.template:
submenu '>$menu_name' --class gnu-linux --class gnu --class os {
$menu_items
}

@SchoolGuy
Copy link
Member Author

@tpw56j Thanks for the suggestion. I will try to apply and check it tomorrow!

SchoolGuy added a commit that referenced this issue Jul 2, 2021
@SchoolGuy
Merge pull request #2694 from cobbler/fix/gh-2693
b68e37b 
Add indicators for the Boot Menus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SchoolGuy SchoolGuy

Labels
3.1.2 Release 3.1.2 enhancement New feature or request
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging a pull request may close this issue.

Add indicators for the Boot Menus cobbler/cobbler
2 participants
@SchoolGuy @tpw56j
0