feat(check): allow running check on commit range #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 43 43
Lines 5992 6002 +10
=======================================
+ Hits 5137 5146 +9
- Misses 855 856 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
✔️ 5314494...c2912bd - Conventional commits check succeeded. |
|
Good job @SanchithHegde ! If you want to make another PR for the error handling don't hesitate to add yourself to the contributor list in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #284.
The changes included in this PR allows accepting the commit range as an optional CLI argument. However,
clapwould raise an error if both--from-latest-tagand commit range are specified. This PR also includes some unit tests, let me know if any more tests are needed.A problem that I see with the current implementation is that parsing a commit range from a string panics if the string is of an invalid format (check the
From<&str>implementation ofRevspecPattern). This would be a bad experience for the users. We should consider implementingFromStrorTryFrominstead, and raise an error instead of panicking. Depending on what's preferable, I can take this up on a separate PR.