8000 [FEATURE] Allow running `cog check` on a commit range · Issue #284 · cocogitto/cocogitto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FEATURE] Allow running cog check on a commit range #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SanchithHegde opened this issue May 7, 2023 · 1 comment · Fixed by #286
Closed

[FEATURE] Allow running cog check on a commit range #284

SanchithHegde opened this issue May 7, 2023 · 1 comment · Fixed by #286
Assignees
@oknozor
Labels
enhancement New feature or request

Comments

@SanchithHegde
Copy link
Contributor

Is your feature request related to a problem? Please describe.

As of now, the cog check command can be run either on all commits, or only on commits starting from the latest tag. There is no option to run cog check on a commit range (say, the commits associated with a PR).

Describe the solution you'd like

It would be preferable if we could have an option to run the cog check command on a commit range as well. I did go through the code, and noticed that the necessary utilities to parse a revision range from a string are already available, so this should be a simple addition. I'd be happy to open a PR if required.

Describe alternatives you've considered

For the exact problem I'm trying to solve (checking commits in a PR for compliance to the conventional commit specification), the cocogitto bot is a solution. However, we also have an additional requirement that the PR title must also comply to the conventional commit specification since we do squash merging. To solve for this, I was hoping to run cog verify against the PR title, and cog check against the commit range in a single workflow. I'm open to any other solutions you may have.

Additional context

N/A
@SanchithHegde SanchithHegde added the enhancement New feature or request label May 7, 2023
@oknozor
Copy link
Collaborator
oknozor commented May 11, 2023

Hey @SanchithHegde, this would be a welcome addition. Feel free to open a PR.

77F8

@SanchithHegde SanchithHegde mentioned this issue May 20, 2023
Merged
@ggirelli ggirelli mentioned this issue Jun 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oknozor oknozor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(check): allow running check on commit range
2 participants
@SanchithHegde @oknozor
0