feat(bump): option to append skip-ci pattern for bump commit #274
Conversation
Codecov Report
@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 85.35% 85.36% +0.01%
==========================================
Files 45 45
Lines 6239 6239
==========================================
+ Hits 5325 5326 +1
+ Misses 914 913 -1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c04aa81 to
d1c600e
Compare
|
Hey @oknozor, I think your merged main into my branch by mistake rather than rebasing it :) |
Absolutely my mistake, sorry. Can you rebase locally and force push ? |
f06f605 to
042dca5
Compare
|
@oknozor No problem, done ;) |
|
@oknozor Do you have any idea about the error ? |
|
Sometimes coverage upload fails, this should not make the CI fail. don't worry though this is not blocking. |
|
Hey @Wassim-AB I think we should also be able to override |
|
Hey @oknozor, no problem, will be working on it today ;) |
f6f34ab to
aa09d63
Compare
|
✔️ fea0ece - Conventional commits check succeeded. |
|
Hey @oknozor, I'm done, I've also renamed the option "skip_ci" instead of "skip_ci_pattern" within the cog.toml, let me know if you're ok with it :) |
|
Hey @oknozor , this would be very useful to get merged. Anything else that needs to be done to move this forward :) ? |
|
Hey @oknozor, will you need some help documenting this feature ? It's fairly easy tbh, it's just out of principle ;) |
|
Hey @Wassim-AB I am merging this now but yes, it would be nice if you could update the doc before next release. |
No description provided.