8000 [FEATURE] Allow to add a [skip ci] when cog create commit · Issue #266 · cocogitto/cocogitto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FEATURE] Allow to add a [skip ci] when cog create commit #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlexisMtr opened this issue Feb 23, 2023 · 5 comments
Closed

[FEATURE] Allow to add a [skip ci] when cog create commit #266

AlexisMtr opened this issue Feb 23, 2023 · 5 comments
Assignees
@oknozor
Labels
enhancement New feature or request

Comments

@AlexisMtr
Copy link

Is your feature request related to a problem? Please describe.
I use cocogitto in my CI system, and I trigger jobs when commits are pushed on my develop and main branch. When I use cog bump, it will create a commit and the CI is triggered when I push it.

Describe the solution you'd like
It would be nice to have an option that allowed me to say "Add [skip ci] pattern at the end of the commit".
Like all CI system use a different pattern to skip build, having a parameter to say which pattern to use seems to be a clever idea

$ cog bump --auto --skip-ci "[skip-ci]"

Thanks for your time
@AlexisMtr AlexisMtr added the enhancement New feature or request label Feb 23, 2023
@Wassim-AB
Copy link

Hey @AlexisMtr and @oknozor

I took the liberty of implementing this feature because I think It would be an awesome addition :)
If you guys wanna have a look : #274

So far you can only specify the skip-ci pattern using the CLI but it would be great to have it specified globally through the cog.toml file :)

Wassim.

@Wassim-AB
Copy link

Hi again @AlexisMtr @oknozor ,

I've been kind of busy recently so I couldn't work on this feature after working on the first one (#271) :)

I've changed the way I implemented this feature and now the option is set directly in the cog.toml file using for example this line :
skip_ci_pattern = "[skip-ci]"

The reason behind this is that adding this feature through the CLI made one function take 8 parameters and Clippy didn't really agree with this ^^

Feel free to take a look -> #274

Wassim.

@Wassim-AB
Copy link

PR Merged and released in 5.5.0 -> https://github.com/cocogitto/cocogitto/releases/tag/5.5.0
The PR for the documentation -> cocogitto/website#57

@oknozor oknozor closed this as completed Aug 18, 2023
@xmlking
Copy link
xmlking commented Aug 19, 2023

will this work only with for bump commands? e.g., cog bump --skip-ci <string>
I like to use this for normal commits as well. for example, don't want my CI to run jobs for commits I know it is a waste of time.

# assume I have  skip_ci = "[skip ci]" in cog.toml
cog commit docs "added cli options" cli --skip-ci

@xmlking
Copy link
xmlking commented Aug 19, 2023 •
edited
Loading

question
if I set skip_ci = "[skip ci]" in cog.toml
will it add "[skip ci]" for every bump ?
what if I want to add skip_ci for selective bump commits?

would be nice if we can enable/disable skip_ci flag via command-line but have the skip_ci = "[skip ci]" in cog.toml

cog bump --auto --skip-ci

@oknozor @Wassim-AB

@Wassim-AB Wassim-AB mentioned this issue Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oknozor oknozor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xmlking @AlexisMtr @oknozor @Wassim-AB
0