8000 fix(bump): bump don't throw error on no bump types commits by Wassim-AB · Pull Request #271 · cocogitto/cocogitto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(bump): bump don't throw error on no bump types commits #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

fix(bump): bump don't throw error on no bump types commits #271

merged 1 commit into from
May 11, 2023

Conversation

Wassim-AB
Copy link
@Wassim-AB Wassim-AB commented Mar 22, 2023 •
edited
Loading

Related issue : #270

@Wassim-AB Wassim-AB changed the title fix: bump command don't throw error on only chore and docs commits WIP: fix: bump command don't throw error on only chore and docs commits Mar 22, 2023
@Wassim-AB Wassim-AB changed the title WIP: fix: bump command don't throw error on only chore and docs commits fix: bump command don't throw error on only chore and docs commits Mar 22, 2023
@Wassim-AB Wassim-AB closed this Mar 22, 2023
@Wassim-AB Wassim-AB reopened this Mar 22, 2023
@Wassim-AB Wassim-AB force-pushed the fix/error-on-no-bump-commits branch from 050ca39 to 905b869 Compare March 22, 2023 09:04
@Wassim-AB Wassim-AB changed the title fix: bump command don't throw error on only chore and docs commits fix(bump): bump don't throw error on only chore and docs commits Mar 22, 2023
@Wassim-AB Wassim-AB mentioned this pull request Mar 22, 2023
Closed
@Wassim-AB Wassim-AB force-pushed the fix/error-on-no-bump-commits branch 4 times, most recently from ca15bf3 to 8bfc2b1 Compare March 22, 2023 14:39
@Wassim-AB Wassim-AB force-pushed the fix/error-on-no-bump-commits branch 5 times, most recently from b73c264 to c856ed6 Compare March 31, 2023 14:22
@Wassim-AB Wassim-AB changed the title fix(bump): bump don't throw error on only chore and docs commits fix(bump): bump don't throw error on no bump types commits Mar 31, 2023
@Wassim-AB Wassim-AB force-pushed the fix/error-on-no-bump-commits branch 5 times, most recently from ed0d468 to c12d6ee Compare April 6, 2023 07:54
@codecov
Copy link
codecov bot commented Apr 16, 2023 •
edited
Loading

Codecov Report

Merging #271 (7f19df1) into main (3c259b6) will increase coverage by 0.02%.
The diff coverage is 88.75%.

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   85.70%   85.73%   +0.02%     
==========================================
  Files          43       43              
  Lines        5926     5992      +66     
==========================================
+ Hits         5079     5137      +58     
- Misses        847      855       +8
Impacted Files Coverage Δ
src/conventional/version.rs 52.17% <0.00%> (+20.59%) ⬆️
src/command/bump/standard.rs 96.92% <50.00%> (-3.08%) ⬇️
src/command/bump/monorepo.rs 92.83% <84.61%> (-0.27%) ⬇️
src/conventional/bump.rs 98.06% <98.11%> (-0.06%) ⬇️
src/command/bump/mod.rs 84.81% <100.00%> (+2.52%) ⬆️
src/command/bump/package.rs 91.78% <100.00%> (+0.60%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oknozor oknozor force-pushed the fix/error-on-no-bump-commits branch from c12d6ee to 7f19df1 Compare May 4, 2023 07:26
@oknozor oknozor merged commit 4a6a8b3 into cocogitto:main May 11, 2023
@Wassim-AB Wassim-AB mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wassim-AB @oknozor
0