feat(cli): Added get-version feature #248
Conversation
2f44c45 to
9cb56c5
Compare
|
I'm sorry, it was too late yesterday.. forgot to rerun reformat and tests once again after changing the selected name for the disable-fallback parameter. |
|
Hey @andre161292 I am sorry but #240 has just been merged and there are now some conflicts. |
|
Thanks for the update. I'll update this as soon as i have some spare time 👍 |
9cb56c5 to
d3684ab
Compare
|
I applied all requested changes, so as soon as there's time, you can do a re-review :) |
src/command/get_version.rs
Outdated
| }; | ||
|
|
||
| warn!("Current version:"); | ||
| print!("{}", current_version); |
There was a problem hiding this comment.
@oknozor why do we need an empty line manually added in cog's main? This makes places like this quite confusing 🤔
There was a problem hiding this comment.
I'm with you.. i wondered about my suddenly failing tests, until i discovered the source
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 84.83% 84.96% +0.13%
==========================================
Files 42 43 +1
Lines 5579 5601 +22
==========================================
+ Hits 4733 4759 +26
+ Misses 846 842 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e87a245 to
6a88d98
Compare
|
Regarding the failing |
|
You probably don't need to worry about the coverage too much, it's advisory for the most part |
6a88d98 to
7ce4aab
Compare
|
✔️ d58831b...7ce4aab - Conventional commits check succeeded. |
7ce4aab to
ee00f5d
Compare
|
As soon as the conflict with main is resolved I think this is ready to be merged @andre161292 :) |
Added the read-only feature "get-version", that will output the latest version
…nd adjusted tests accordingly
Co-authored-by: Marcin Puc <tranzystorek.io@protonmail.com>
ee00f5d to
c13c086
Compare
|
Check ✔️ |
|
Thank you @andre161292 :) |
Added the read-only feature "get-version", that will output the latest version, if any.
Closes #222