8000 feat: monorepo support by oknozor · Pull Request #240 · cocogitto/cocogitto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: monorepo support #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jan 19, 2023
Merged

feat: monorepo support #240

merged 26 commits into from
Jan 19, 2023

Conversation

oknozor
Copy link
Collaborator
@oknozor oknozor commented Oct 28, 2022 •
edited
Loading

Todos:

  • [x] match latest tag by date when dealing with monorepo instead of semver ordering (latest package tag could be lower than some older package tags)
  • execute packages hooks only when a package version is upgraded
  • automatically add tag prefix from repo package names
  • add a changelog template dedicated to monorepos
  • add the an option to generate separate changelogs for monorepo packages
  • Aggregate monorepo package changelog updates to root changelog
  • Global changelog should only be updated by package marked as public_api (default: true)
  • Run package hooks within package path
  • Rework pretty print
  • Ensure hook dsl is working with package versions
  • tests
    • monorepo bump
    • single package bump
  • Update changelog templates
    • full_hash
    • monorepo_full_hash
    • monorepo_remote
    • monorepo_simple
    • package_full_hash
    • package_remote
    • package_simple
  • Add manual bump support for monorepo
  • Update docs
  • squash PR commits

Closes #232

@oknozor oknozor force-pushed the feat/monorepo branch 2 times, most recently from 9fc2cb7 to 481f1fc Compare October 29, 2022 13:00
@oknozor oknozor changed the title WIP feat: monorepo support Oct 29, 2022
@oknozor
Copy link
Collaborator Author
oknozor commented Oct 31, 2022

Hey @tranzystorek-io this is far from being done but it brings a lot of changes to the tag serialization/deserialization.
There is no hurry but an early review would be appreciated.

I think I might managed to release this without making it a breaking change but I am not sure yet. Let me know what you think.

@oknozor oknozor requested a review from tranzystorekk October 31, 2022 10:50
@tranzystorekk
Copy link
Contributor

An unexpected but welcome change 😄

@blaggacao
Copy link
Contributor

How can I help to move this forward?

@oknozor oknozor mentioned this pull request Jan 15, 2023
Closed
@oknozor oknozor added the enhancement New feature or request label Jan 16, 2023
@oknozor oknozor force-pushed the feat/monorepo branch 3 times, most recently from 16fe5ea to de337ed Compare January 17, 2023 14:50
@oknozor
Copy link
Collaborator Author
oknozor commented Jan 17, 2023

How can I help to move this forward?

Hey @blaggacao sorry for the late reply, this feature is hard to split in smaller tasks unfortunately.
I am actively working on it and will release it soon though. Thanks for your patience.

@oknozor
Copy link
Collaborator Author
oknozor commented Jan 18, 2023

@tranzystorek-io @blaggacao I am almost there !

Here are some generated changelog examples:

Tell me if you think something is missing.

@oknozor oknozor marked this pull request as ready for review January 18, 2023 17:47
@cocogitto cocogitto deleted a comment from codecov bot Jan 18, 2023
@jmgilman
Copy link
jmgilman commented Jan 18, 2023 •
edited
Loading

Thanks for working on this! Examples look good to me.

@blaggacao
Copy link
Contributor
blaggacao commented Jan 18, 2023 •
edited
Loading

Wonderful! Looks good to go, we'll test drive this in our team as soon as we can free a spot. But cocogitto had been chosen long time ago as centerpiece for Standard's interpretation of the SDLC.

@codecov
Copy link
codecov bot commented Jan 19, 2023 •
edited
Loading

Codecov Report

Merging #240 (763a2d4) into main (3a356cc) will increase coverage by 3.24%.
The diff coverage is 90.56%.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   81.83%   85.07%   +3.24%     
==========================================
  Files          30       42      +12     
  Lines        3969     5495    +1526     
==========================================
+ Hits         3248     4675    +1427     
- Misses        721      820      +99
Impacted Files Coverage Δ
src/bin/cog/commit.rs 10.00% <0.00%> (ø)
src/command/edit.rs 0.00% <0.00%> (ø)
src/conventional/changelog/error.rs 0.00% <0.00%> (ø)
src/error.rs 50.00% <ø> (ø)
src/git/error.rs 38.46% <0.00%> (-9.22%) ⬇️
src/lib.rs 28.20% <ø> (-38.69%) ⬇️
src/conventional/version.rs 31.57% <31.25%> (-67.10%) ⬇️
src/command/log.rs 68.57% <68.57%> (ø)
src/command/bump/mod.rs 77.82% <77.82%> (ø)
src/command/init.rs 80.95% <80.95%> (ø)
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cocogitto-bot
Copy link
cocogitto-bot bot commented Jan 19, 2023

✔️ c224e98...763a2d4 - Conventional commits check succeeded.

@oknozor oknozor merged commit d8eed3d into main Jan 19, 2023
@oknozor oknozor mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tranzystorekk tranzystorekk Awaiting requested review from tranzystorekk

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] add support for monorepo
4 participants
@oknozor @tranzystorekk @blaggacao @jmgilman
0