8000 feat(componentInstance): add parentId support to ComponentInstance by dustindemmerle · Pull Request #743 · cloudoperators/heureka · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(componentInstance): add parentId support to ComponentInstance #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat(componentInstance): add parentId support to ComponentInstance #743

wants to merge 23 commits into from

Conversation

dustindemmerle
Copy link
Collaborator

Description

This PR enforces business logic for the Component Instance entity: as of now a parent_id can only be set if the component_instance_type is either "DnsZone" or "User". Attempts to assign a parent_id to other types will now result in a error. This ensures data from the openstack scanner can be sent to Heureka

This PR also includes Michals bug fixes manually added

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #693

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

DB, API & E2E test

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@michalkrzyz
Fix heureka cmd migration
1f2f0ec 
On-behalf-of: SAP Michal Krzyz <michal.krzyz@sap.com>
Signed-off-by: Michal Krzyz <michalkrzyz@gmail.com>
michalkrzyz
michalkrzyz reviewed Jun 12, 2025
View reviewed changes
@dustindemmerle dustindemmerle marked this pull request as ready for review June 12, 2025 09:36
@dustindemmerle
feat(componentInstance): add parentId support to ComponentInstance
8000
e47df63
@dustindemmerle
feat(componentInstance): add validation for ParentId in Create and Up…
3fd8f58 
…date methods

fix(database): update ResetSchema to accept dbName parameter and adjust related logic - changes from Michals branch
chore(Makefile): reorder dependencies in build and run targets
@dustindemmerle dustindemmerle force-pushed the dustindemmerle/issue-693/new_component-instance_self-referencing branch from e172f93 to 3fd8f58 Compare June 12, 2025 10:13
@dustindemmerle dustindemmerle changed the base branch from main to mikrzyz/fix-heureka-cmd-migration June 12, 2025 10:15
michalkrzyz
michalkrzyz reviewed Jun 13, 2025
View reviewed changes
@michalkrzyz michalkrzyz force-pushed the mikrzyz/fix-heureka-cmd-migration branch from fe8cbe5 to b78671e Compare June 13, 2025 11:08
michalkrzyz
michalkrzyz requested changes Jun 13, 2025
View reviewed changes
michalkrzyz
michalkrzyz reviewed Jun 13, 2025
View reviewed changes
@michalkrzyz michalkrzyz force-pushed the mikrzyz/fix-heureka-cmd-migration branch from 41c13d3 to 6fe8d73 Compare June 23, 2025 15:45
Base automatically changed from mikrzyz/fix-heureka-cmd-migration to main June 24, 2025 06:55
MR2011
MR2011 reviewed Jun 24, 2025
View reviewed changes
MR2011
MR2011 reviewed Jun 24, 2025
View reviewed changes
MR2011
MR2011 reviewed Jun 24, 2025
View reviewed changes
MR2011
MR2011 reviewed Jun 24, 2025
View reviewed changes
@dustindemmerle dustindemmerle requested a review from MR2011 June 25, 2025 13:46
cesardsoto and others added 12 commits June 25, 2025 15:49
@cesardsoto @michalkrzyz
@MR2011 @dustindemmerle
feat(user): support mailing list (#745)
3fafb68 
* Fix heureka cmd migration

On-behalf-of: SAP Michal Krzyz <michal.krzyz@sap.com>
Signed-off-by: Michal Krzyz <michalkrzyz@gmail.com>

* feat(user): add mail list as user type and add email to user table

* Automatic application of license header

* feat(user): changes to Makefile

---------

Signed-off-by: Michal Krzyz <michalkrzyz@gmail.com>
Co-authored-by: Michal Krzyz <michalkrzyz@gmail.com>
Co-authored-by: I753677 <cesar.soto01@sap.com>
Co-authored-by: License Bot <license_bot@github.com>
Co-authored-by: Michael Reimsbach <MR201190@gmail.com>
@MR2011 @dustindemmerle
chore: setup semantic-release (#749)
5477dc7
@MR2011 @dustindemmerle
feat: add semantic release dry run (#750) 8000
8bcd269 
* chore: setup semantic-release

* feat: add semantic release dry run
@MR2011 @dustindemmerle
chore: remove semantic-release dependencies (#751)
d7caf3a 
* chore: setup semantic-release

* feat: add semantic release dry run

* chore: remove semantic-release dependencies
@MR2011 @dustindemmerle
chore: move image build to release workflow (#752)
d51135c 
* chore: setup semantic-release

* feat: add semantic release dry run

* chore: remove semantic-release dependencies

* chore: move image build to release workflow
@MR2011 @dustindemmerle
chore: use docker/metadata-action's builtin version handling (#753)
4901650 
* chore: setup semantic-release

* feat: add semantic release dry run

* chore: remove semantic-release dependencies

* chore: move image build to release workflow

* chore: use docker/metadata-action's builtin version handling
@MR2011 @dustindemmerle
chore: set initial version to 0.1.0 (#754)
c7c3341 
* chore: setup semantic-release

* feat: add semantic release dry run

* chore: remove semantic-release dependencies

* chore: move image build to release workflow

* chore: use docker/metadata-action's builtin version handling

* chore: set initial version to 0.1.0
@dustindemmerle
feat(componentInstance): add parentId support to ComponentInstance
d387da2
@dustindemmerle
fix(database): correct foreign key constraints and modify component i…
627488a 
…nstance types
@MR2011 @dustindemmerle
chore: update version tagging (#755)
84ea096 
* chore: setup semantic-release

* feat: add semantic release dry run

* chore: remove semantic-release dependencies

* chore: move image build to release workflow

* chore: use docker/metadata-action's builtin version handling

* chore: set initial version to 0.1.0

* chore: update version tagging
@dustindemmerle
Merge branch 'main' into dustindemmerle/issue-693/new_component-insta…
27b67c1 
…nce_self-referencing
Automatic application of license header
f81bc82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drochow drochow Awaiting requested review from drochow drochow is a code owner

@dorneanu dorneanu Awaiting requested review from dorneanu dorneanu is a code owner

@copyonwrite copyonwrite Awaiting requested review from copyonwrite copyonwrite is a code owner

@MR2011 MR2011 Awaiting requested review from MR2011 MR2011 is a code owner

@michalkrzyz michalkrzyz Awaiting requested review from michalkrzyz michalkrzyz is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(componentInstance): Enable self-referencing
4 participants
@dustindemmerle @MR2011 @michalkrzyz @cesardsoto
0