8000 feat(user): support mailing list by cesardsoto · Pull Request #745 · cloudoperators/heureka · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(user): support mailing list #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 25, 2025
Merged

feat(user): support mailing list #745

merged 5 commits into from
Jun 25, 2025
+71 −26

Conversation

cesardsoto
Copy link
Collaborator
@cesardsoto cesardsoto commented Jun 16, 2025 •
edited
Loading

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

michalkrzyz and others added 2 commits June 10, 2025 17:40
@michalkrzyz
Fix heureka cmd migration
1f2f0ec 
On-behalf-of: SAP Michal Krzyz <michal.krzyz@sap.com>
Signed-off-by: Michal Krzyz <michalkrzyz@gmail.com>
feat(user): add mail list as user type and add email to user table
ad1f247
@cesardsoto cesardsoto changed the title Cesardsoto/issue 729/support mailing list feat(user): support mailing list Jun 16, 2025
michalkrzyz
michalkrzyz reviewed Jun 20, 2025
View reviewed changes
internal/database/mariadb/test/database_manager.go Outdated
@@ -122,7 +122,7 @@ func (dbm *LocalTestDataBaseManager) Setup() error {
return nil
}

func (dbm *LocalTestDataBaseManager) ResetSchema() error {
func (dbm *LocalTestDataBaseManager) ResetSchema(dbName string) error {
Copy link
Collaborator

Choose a reason for hi 8000 ding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase to #742 please

michalkrzyz
michalkrzyz previously approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator
@michalkrzyz michalkrzyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this branch onto #742. The rest of the changes look good and are approved.

@MR2011
Copy link
Collaborator
MR2011 commented Jun 24, 2025

@cesardsoto Please remove again the Makefile changes. The CodeQL GH action is failing due to that

@MR2011 MR2011 merged commit 749743f into main Jun 25, 2025
8 of 9 checks passed
@MR2011 MR2011 deleted the cesardsoto/issue_729/support_mailing_list branch June 25, 2025 07:14
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dustindemmerle pushed a commit that referenced this pull request Jun 25, 2025
@cesardsoto @michalkrzyz
@MR2011 @dustindemmerle
feat(user): support mailing list (#745)
3fafb68 
* Fix heureka cmd migration

On-behalf-of: SAP Michal Krzyz <michal.krzyz@sap.com>
Signed-off-by: Michal Krzyz <michalkrzyz@gmail.com>

* feat(user): add mail list as user type and add email to user table

* Automatic application of license header

* feat(user): changes to Makefile

---------

Signed-off-by: Michal Krzyz <michalkrzyz@gmail.com>
Co-authored-by: Michal Krzyz <michalkrzyz@gmail.com>
Co-authored-by: I753677 <cesar.soto01@sap.com>
Co-authored-by: License Bot <license_bot@github.com>
Co-authored-by: Michael Reimsbach <MR201190@gmail.com>
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

1 similar comment
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2 similar comments
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MR2011 MR2011 MR2011 approved these changes

@michalkrzyz michalkrzyz michalkrzyz left review comments

@drochow drochow Awaiting requested review from drochow drochow is a code owner

@dorneanu dorneanu Awaiting requested review from dorneanu dorneanu is a code owner

@copyonwrite copyonwrite Awaiting requested review from copyonwrite copyonwrite is a code owner

Assignees
No one assigned
Labels
released on @latest released on @mr2011/semantic-release released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(user): support mailing list
3 participants
@cesardsoto @MR2011 @michalkrzyz
0