-
-
Notifications
You must be signed in to change notification settings - Fork 87
fix: addressing some unanticipated situations #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PTAL @sindresorhus |
CI is failing and this PR needs a proper title. |
Okay, I'll try to modify. |
done |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not particularly fond of these changes but with the requested change it isn't the worst I suppose.
Maybe I'm missing something (your PR doesn't explain what these changes actually do...) but what are the changes in the browser implementation trying to achieve?
Starting with the specified version, Chromium's console can output true color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look better.
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@idanran Can you submit these changes to Chalk too? Which bundles this package. |
No problem. |
Avoid requesting unnecessary permissions when used by Deno users.
Modern Chromium supports true color.