8000 feat: support deno and modern chromium by idranme · Pull Request #141 · chalk/supports-color · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support deno and modern chromium #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat: support deno and modern chromium #141

w 8000 ants to merge 3 commits into from

Conversation

idranme
Copy link
Contributor
@idranme idranme commented Nov 24, 2022

No description provided.

@idranme
Copy link
Contributor Author
idranme commented Nov 24, 2022

PTAL @sindresorhus

@sindresorhus
Copy link
Member

Deno supports Node.js packages. We are not going to add lots of custom code for Deno.

@sindresorhus
Copy link
Member

As for the Firefox support, can you link to a source that documents the support for ANSI escapes?

@idranme
Copy link
Contributor Author
idranme commented Nov 25, 2022

Deno supports Node.js packages. We are not going to add lots of custom code for Deno.

But the polyfill it introduces automatically can cause unnecessary privileges to be requested. And it also reduces the speed of starting work.
image
image

@idranme
Copy link
Contributor Author
idranme commented Nov 25, 2022 •
edited
Loading

As for the Firefox support, can you link to a source that documents the support for ANSI escapes?

It really doesn't support ANSI, which I was wrong about. I will fix it.

@sindresorhus
Copy link
Member

But the polyfill it introduces automatically can cause unnecessary privileges to be requested.

You should open an issue on Deno about that. This sounds like a bug in the polyfill.

@idranme idranme changed the title feat: support deno and firefox feat: support deno and modern chromium Nov 25, 2022
@idranme
Copy link
Contributor Author
idranme commented Nov 25, 2022 •
edited
Loading

But the polyfill it introduces automatically can cause unnecessary privileges to be requested.

You should open an issue on Deno about that. This sounds like a bug in the polyfill.

I'm not sure if this is a bug, but I can sure that introducing polyfill slows down startup.

@idranme idranme closed this Nov 27, 2022
@idranme idranme mentioned this pull request Nov 27, 2022
Closed
@idranme
Copy link
Contributor Author
idranme commented Nov 28, 2022 •
edited
Loading

But the polyfill it introduces automatically can cause unnecessary privileges to be requested.

You should open an issue on Deno about that. This sounds like a bug in the polyfill.

denoland/deno#16848 (comment)
This is not a bug in polyfill.

@idranme idranme reopened this Nov 28, 2022
@Qix-
Copy link
Member
Qix- commented Nov 28, 2022

Not a huge fan of this. For years javascript standards have diverged creating hell on earth for package maintainers. This seems to be multiplicative maintenance overhead...

@idranme
Copy link
Contributor Author
idranme commented Nov 28, 2022

Not a huge fan of this. For years javascript standards have diverged creating hell on earth for package maintainers. This seems to be multiplicative maintenance overhead...

I will open a PR later to rework it. I believe we can solve this problem.

@idranme idranme closed this by deleting the head repository Nov 28, 2022
@idranme
Copy link
Contributor Author
idranme commented Nov 28, 2022

Not a huge fan of this. For years javascript standards have diverged creating hell on earth for package maintainers. This seems to be multiplicative maintenance overhead...

See #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idranme @sindresorhus @Qix- @idanran
0