-
Notifications
You must be signed in to change notification settings - Fork 21
[16.0] update i18n italy #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
Warning Rate limit exceeded@mymage has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 58 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
WalkthroughItalian translation files for four Odoo modules ( Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
cetmix_tower_aws/i18n/it.po
(1 hunks)cetmix_tower_git/i18n/it.po
(6 hunks)cetmix_tower_server/i18n/it.po
(13 hunks)cetmix_tower_yaml/i18n/it.po
(9 hunks)
🧰 Additional context used
🧠 Learnings (2)
cetmix_tower_server/i18n/it.po (1)
undefined
<retrieved_learning>
Learnt from: ivs-cetmix
PR: #146
File: cetmix_tower_yaml/wizards/cx_tower_yaml_export_wiz.py:59-60
Timestamp: 2024-11-23T22:16:52.213Z
Learning: In the cetmix_tower_yaml
module of the Odoo framework, all models that inherit from CxTowerYamlMixin
are required to have a mandatory reference
attribute.
</retrieved_learning>
cetmix_tower_yaml/i18n/it.po (1)
Learnt from: ivs-cetmix
PR: cetmix/cetmix-tower#146
File: cetmix_tower_yaml/wizards/cx_tower_yaml_export_wiz.py:59-60
Timestamp: 2024-11-23T22:16:52.213Z
Learning: In the `cetmix_tower_yaml` module of the Odoo framework, all models that inherit from `CxTowerYamlMixin` are required to have a mandatory `reference` attribute.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: test with OCB
- GitHub Check: test with Odoo
🔇 Additional comments (20)
cetmix_tower_git/i18n/it.po (6)
10-10
: Approved: PO-Revision-Date updated
The revision date2025-05-29 22:27+0200
correctly reflects the latest translation changes.
126-129
: Approved: Added context for reference field
Including thefield_cx_tower_git_project_rel__reference
context aligns with the updated model and ensures these help texts are translated.
351-355
: Approved: New translation entry for “Git Project Relations”
The new entry and its Italian translation are consistent with other relation labels in this file.
646-650
: Approved: Added server field context
The added context forfield_cx_tower_file__server_id
andfield_cx_tower_git_project_rel__server_id
correctly maps this new field for translation.
732-735
: Approved: Added YAML code field context
The inclusion offield_cx_tower_git_project_rel__yaml_code
ensures the new YAML code field is covered by translations.
18-18
: Nitpick: Plural-Forms consistency
The header usesplural=n != 1;
without parentheses, whereas some modules useplural=(n != 1);
. Please verify this syntax is accepted by Odoo.cetmix_tower_server/i18n/it.po (7)
10-10
: Update PO revision date
ThePO-Revision-Date
has been updated correctly to reflect the latest changes.
298-305
: Added new copy suffix variant with numbering
The newmsgid "%(name)s (copy %(number)s)"
and its translation are correct and consistent with the variant including the copy number.
306-312
: Translated copy suffix without numbering
The translation for%(name)s (copy)
as%(name)s (copia)
is accurate and matches the source.
680-684
: New "Binary Content" translation
The entry for"Binary Content"
has been added and translated correctly as"Contenuto binario"
.
687-690
: Context references for newreference
fields
The help context lines have been updated to include the newfile__reference
andkey_value__reference
fields, ensuring consistency across models.
2533-2537
: Translation for "No Split for sudo"
The new labelNo Split for sudo
and its translation"Non dividere per sudo"
appear correct and convey the intended meaning.
1305-1308
:⚠️ Potential issueGender agreement in translation
The translation of"Custom Variable Value"
should match the masculine noun valore.
[suggested] change themsgstr
to"Valore variabile personalizzato"
.-msgstr "Valore variabile personalizzata" +msgstr "Valore variabile personalizzato"Likely an incorrect or invalid review comment.
cetmix_tower_yaml/i18n/it.po (7)
10-10
: Standard localization update.The PO-Revision-Date has been updated to reflect the current revision timestamp, which is standard practice for translation file maintenance.
97-100
: New model translation added correctly.The Italian translation for "Cetmix Tower File" model has been added appropriately. The translation "File Cetmix Tower" follows the established naming pattern used for other model translations in this file.
132-141
: New model translations integrated properly.Two new model translations have been added:
- "Cetmix Tower Secret Value Storage" → "Archivio valore segreto Cetmix Tower"
- "Cetmix Tower Server" → "Server Cetmix Tower"
The translations are grammatically correct and maintain consistency with the existing naming conventions in the file.
290-290
: YAML export functionality extended to server model.The server model has been properly integrated into the YAML export actions and view forms, enabling users to export server configurations as YAML. This aligns with the module's goal of providing comprehensive YAML export/import capabilities.
Also applies to: 300-300
424-425
: Error message correction implemented.The error message has been corrected from referencing "server" to "command_run_wizard", which provides more accurate feedback to users about unsupported YAML import models. This correction improves the user experience by providing clearer error messaging.
644-644
: YAML code fields added for new models.The yaml_code field descriptions have been properly added for the new models (cx_tower_file, cx_tower_key_value, cx_tower_server), ensuring users have appropriate field labels when working with YAML functionality for these entities.
Also applies to: 647-647, 652-652
598-598
: View form references updated consistently.The server model view form has been properly referenced in the YAML-related UI elements, ensuring consistent user interface labeling and maintaining the cohesive user experience across the YAML export/import functionality.
Also applies to: 697-697
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (4)
cetmix_tower_aws/i18n/it.po (1)
14-18
: PO-Revision-Date is present but emptyThe PO-Revision-Date field is now included in the header but lacks a value. Consider adding the current date and time to help track when this translation was last updated.
cetmix_tower_server/i18n/it.po (3)
2068-2076
: Previously flagged spacing issue persistsThe spacing issue in the English msgid was previously identified but remains unfixed. The Italian translation correctly adds the missing space.
4038-4042
: Previously flagged plural mismatch persistsThe plural mismatch in the translation of "Triggered Commands" was previously flagged but remains unfixed.
4043-4047
: Previously flagged grammar improvement persistsThe grammar improvement suggestion for "Triggered Flight Plan Commands" was previously flagged but not implemented.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
cetmix_tower_aws/i18n/it.po
(1 hunks)cetmix_tower_git/i18n/it.po
(6 hunks)cetmix_tower_server/i18n/it.po
(13 hunks)cetmix_tower_yaml/i18n/it.po
(9 hunks)
🧰 Additional context used
🧠 Learnings (2)
cetmix_tower_server/i18n/it.po (1)
undefined
<retrieved_learning>
Learnt from: ivs-cetmix
PR: #146
File: cetmix_tower_yaml/wizards/cx_tower_yaml_export_wiz.py:59-60
Timestamp: 2024-11-23T22:16:52.213Z
Learning: In the cetmix_tower_yaml
module of the Odoo framework, all models that inherit from CxTowerYamlMixin
are required to have a mandatory reference
attribute.
</retrieved_learning>
cetmix_tower_yaml/i18n/it.po (1)
Learnt from: ivs-cetmix
PR: cetmix/cetmix-tower#146
File: cetmix_tower_yaml/wizards/cx_tower_yaml_export_wiz.py:59-60
Timestamp: 2024-11-23T22:16:52.213Z
Learning: In the `cetmix_tower_yaml` module of the Odoo framework, all models that inherit from `CxTowerYamlMixin` are required to have a mandatory `reference` attribute.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: test with OCB
- GitHub Check: test with Odoo
🔇 Additional comments (21)
cetmix_tower_aws/i18n/it.po (3)
24-32
: LGTM: Accurate Italian translation for boto3 descriptionThe plain text translation of the boto3 library description is accurate and maintains the technical terminology appropriately. The translation properly conveys the information about available methods and supported AWS services.
37-51
: LGTM: HTML translation with corrected grammarThe HTML-formatted translation correctly preserves the markup structure and includes the properly contracted "sui servizi e sui metodi" instead of the previously flagged "su i servizi e i metodi". The translation maintains the technical accuracy while following proper Italian grammar.
52-56
: LGTM: Simple and accurate model name translationThe translation of "Cetmix Tower Command" to "Comando Cetmix Tower" is straightforward and appropriate for the Italian locale.
cetmix_tower_git/i18n/it.po (6)
10-10
: LGTM: PO-Revision-Date properly updatedThe revision date has been updated to a proper format with timezone information (2025-05-29 22:27+0200), which helps track when this translation was last modified.
125-126
: LGTM: Field reference expansion for consistencyThe addition of 8000 the
cx_tower_git_project_rel__reference
field reference to the existing help text maintains consistency with the translation structure and properly links the help text to all relevant model fields.
351-354
: LGTM: Accurate translation for new fieldThe translation "Git Project Relations" → "Relazioni progetto Git" is grammatically correct and consistent with the terminology used throughout the file for similar concepts.
591-592
: LGTM: Reference field addition for project relationsAdding the
cx_tower_git_project_rel__reference
field reference to the existing "Reference" translation entry ensures comprehensive coverage of all model fields that use this translation.
645-646
: LGTM: Server field reference expansionThe addition of the
cx_tower_file__server_id
field reference expands the coverage of the "Server" translation to include file-related server fields, maintaining translation consistency across the module.
731-732
: LGTM: YAML code field reference additionAdding the
cx_tower_git_project_rel__yaml_code
field reference ensures that the "Yaml Code" translation covers all relevant model fields, including project relation fields.cetmix_tower_server/i18n/it.po (5)
1969-1971
: Verify if empty translation is intentionalThe English text "Host key is missing!" has an empty Italian translation. Please confirm if this should remain untranslated or if an Italian translation is needed.
If a translation is needed, consider:
msgid "Host key is missing!" -msgstr "" +msgstr "Chiave host mancante!"
298-312
: LGTM! Copy suffix translationsThe copy suffix translations are correctly implemented using the proper Italian term "copia" with appropriate grammatical structures.
680-684
: LGTM! Binary content translationThe translation of "Binary Content" to "Contenuto binario" is accurate and appropriate.
1305-1308
: LGTM! Custom variable value translationThe translation correctly uses the feminine form "personalizzata" to agree with "variabile" (feminine gender in Italian).
2534-2537
: LGTM! No Split for sudo translationThe translation "Non dividere per sudo" accurately conveys the meaning of the English text.
cetmix_tower_yaml/i18n/it.po (7)
10-10
: LGTM: Standard revision date update.The PO-Revision-Date update follows standard practice for translation file maintenance.
132-136
: LGTM: Proper translation for Secret Value Storage model.The Italian translation "Archivio valore segreto Cetmix Tower" accurately reflects the English meaning and is consistent with similar translations in the file.
137-141
: LGTM: Proper translation for Server model.The Italian translation "Server Cetmix Tower" is accurate and consistent with the naming convention used throughout the file.
290-290
: LGTM: Consistent addition of server export action references.The additions properly integrate the cx_tower_server model into the YAML export functionality, maintaining consistency with other model references.
Also applies to: 300-300
424-425
: LGTM: Corrected error message translation.The fix from "server" to "command_run_wizard" in the error message accurately reflects the model that doesn't support YAML import.
644-644
: LGTM: Complete YAML code field coverage for new models.The additions ensure all new models (cx_tower_file, cx_tower_key_value, cx_tower_server) have proper YAML code field references, maintaining feature completeness.
Also applies to: 647-647, 652-652
598-598
: LGTM: Consistent UI message integration.The server view form references are properly integrated into the YAML export permission messages, maintaining UI consistency.
Also applies to: 697-697
440bcc6
to
0b66890
Compare
Update it.po files
Summary by CodeRabbit
New Features
Enhancements
Cleanup