8000 chore(sdk): Bump up pyfunc package versions by deadlycoconuts · Pull Request #649 · caraml-dev/merlin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(sdk): Bump up pyfunc package versions #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 19, 2025
Merged

chore(sdk): Bump up pyfunc package versions #649

merged 7 commits into from
May 19, 2025

Conversation

deadlycoconuts
Copy link
Contributor
@deadlycoconuts deadlycoconuts commented May 15, 2025 •
edited
Loading

Description

Given that the current release of Merlin is v0.48.3, we need to update the default version of the merlin-batch-predictor and merlin-pyfunc-server Python packages.

Additional Unrelated Changes 🚨

Due to the upgrading of numpy in this PR here, Python 3.8 is no longer supported. The CICD pipeline fails because Python 3.8 is currently still being used. This draft (at the time of writing) PR #639 is supposed to include changes to remove support for Python 3.8 but is temporarily paused due to other changes. @naufalandika

To fix the CICD pipeline for the moment, this PR copies the existing changes in that PR to remove support entirely for Python 3.8 (and includes other changes to other tests/examples that mention Python 3.8).

Modifications

  • python/sdk/merlin/model.py - Bumped up max version of the merlin-batch-predictor and merlin-pyfunc-server Python packages

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

NONE

@deadlycoconuts deadlycoconuts requested review from shydefoo and bthari May 15, 2025 09:44
@deadlycoconuts deadlycoconuts self-assigned this May 15, 2025
@deadlycoconuts deadlycoconuts added the maintenance Dependency updates and other chores label May 15, 2025
@deadlycoconuts deadlycoconuts marked this pull request as ready for review May 19, 2025 04:05
deadlycoconuts
deadlycoconuts commented May 19, 2025
View reviewed changes
shydefoo
shydefoo approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor
@shydefoo shydefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing this!

naufalandika
naufalandika approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor
@naufalandika naufalandika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deadlycoconuts
Copy link
Contributor Author

Thanks for the quick review everyone!

@deadlycoconuts deadlycoconuts merged commit fbbdd3a into main May 19, 2025
32 checks passed
@deadlycoconuts deadlycoconuts deleted the bump_up_default_pyfunc_lib_versions branch May 19, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shydefoo shydefoo shydefoo approved these changes

@naufalandika naufalandika naufalandika approved these changes

@bthari bthari Awaiting requested review from bthari

Assignees

@deadlycoconuts deadlycoconuts

Labels
maintenance Dependency updates and other chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deadlycoconuts @shydefoo @naufalandika
0