fix: fix failing action in Merlin CI Workflow #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b36288 to
cd43ee1
Compare
added 27 commits
April 14, 2025 15:21
added 9 commits
April 16, 2025 15:00
de8daa0 to
b834426
Compare
6 tasks
deadlycoconuts
added a commit
that referenced
this pull request
May 19, 2025
# Description Given that the current release of Merlin is `v0.48.3`, we need to update the default version of the `merlin-batch-predictor` and `merlin-pyfunc-server` Python packages. ## Additional Unrelated Changes 🚨 Due to the upgrading of `numpy` in this PR [here](#641 (comment)), Python 3.8 is no longer supported. The CICD pipeline fails because Python 3.8 is currently still being used. This draft (at the time of writing) PR #639 is supposed to include changes to remove support for Python 3.8 but is temporarily paused due to other changes. @naufalandika To fix the CICD pipeline for the moment, this PR copies the existing changes in that PR to remove support entirely for Python 3.8 (and includes other changes to other tests/examples that mention Python 3.8). # Modifications - `python/sdk/merlin/model.py` - Bumped up max version of the `merlin-batch-predictor` and `merlin-pyfunc-server` Python packages # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [x] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [x] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...
Modifications
remove deprecated package from setup.py, run pip install in Dock