8000 fix(engine): disable feedback by NDStrahilevitz · Pull Request #4803 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(engine): disable feedback #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(engine): disable feedback #4803

wants to merge 2 commits into from

Conversation

NDStrahilevitz 8000
Copy link
Collaborator
@NDStrahilevitz NDStrahilevitz commented Jun 23, 2025 •
edited
Loading

1. Explain what the PR does

77d211e fix(engine):disable feedback

Feedback from findings back into the engines could cause a deadlock.
This is because the engine would eventually block on trying to to send
a new event to the feedbacking signature. This would cause a deadlock
there - propagating back to the engine and pipeline in general.

Commenting out the feedback for now.

2. Explain how to test it

Confirmed in internal e2e - submit failures with mass verification failure stopped.

3. Other comments

@NDStrahilevitz NDStrahilevitz requested a review from geyslan June 23, 2025 14:31
@NDStrahilevitz NDStrahilevitz self-assigned this Jun 23, 2025
@Copilot Copilot AI review requested due to automatic review settings June 23, 2025 14:31
Copilot
Copilot AI reviewed Jun 23, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR disables the feedback functionality within the engine to prevent a deadlock as explained in the commit message.

  • The feedback-related code has been commented out to avoid potential deadlock scenarios.
  • The overall engine behavior is modified to stop feeding back events.

@NDStrahilevitz
fix(engine):disable feedback
77d211e 
Feedback from findings back into the engines could cause a deadlock.
This is because the engine would eventually block on trying to to send
a new event to the feedbacking signature. This would cause a deadlock
there - propagating back to the engine and pipeline in general.

Commenting out the feedback for now.
@NDStrahilevitz NDStrahilevitz changed the title disable feedback fix(engine):disable feedback Jun 23, 2025
@NDStrahilevitz NDStrahilevitz changed the title fix(engine):disable feedback fix(engine): disable feedback Jun 23, 2025
geyslan
geyslan approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member
@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NDStrahilevitz NDStrahilevitz mentioned this pull request Jun 23, 2025
Draft
@NDStrahilevitz NDStrahilevitz marked this pull request as draft June 23, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@geyslan geyslan geyslan approved these changes

@yanivagman yanivagman Awaiting requested review from yanivagman

Assignees

@NDStrahilevitz NDStrahilevitz

Labels
area/ebpf area/signatures area/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NDStrahilevitz @geyslan
0