[v0.23.2] PR #4803: fix(engine): disable feedback #4804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: 77d211e (main), cherry-pick
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables the engine’s feedback mechanism to avoid a deadlock when sending events back into the pipeline.
- Removes the
findingsimport. - Comments out the feedback conversion and send logic with a TODO explaining the deadlock.
Comments suppressed due to low confidence (2)
pkg/signatures/engine/engine.go:152
- There's a duplicated 'to' in this comment ("trying to to send"). Consider removing the extra 'to' for clarity.
// a new event to the feedbacking signature. This would cause a deadlock
pkg/signatures/engine/engine.go:150
- [nitpick] The term "feedbacking signature" is unclear; consider rephrasing to "feedback signature" or "signature receiving feedback" for clarity.
// when the engine was blocked on sending a new event to the feedbacking signature.
Comment on lines
+149
to
+165
| // TODO: the feedback is disabled for now, as it was causing a deadlock | ||
| // when the engine was blocked on sending a new event to the feedbacking signature. | ||
| // This is because the engine would eventually block on trying to to send | ||
| // a new event to the feedbacking signature. This would cause a deadlock | ||
| // there - propagating back to the engine and pipeline in general. | ||
| // We should keep it here for reference until we find a better solution. | ||
| // if !engine.config.Enabled { | ||
| // return | ||
| // // next section is relevant only for engine-in-pipeline and analyze | ||
| // } | ||
| // e, err := findings.FindingToEvent(res) | ||
| // if err != nil { | ||
| // logger.Errorw("Failed to convert finding to event, will not feedback", "err", err) | ||
| // return | ||
| // } | ||
| // prot := e.ToProtocol() | ||
| // engine.inputs.Tracee <- prot |
There was a problem hiding this comment.
Remove the large commented-out feedback block (lines 155–165). If you need to disable feedback temporarily, consider using a feature flag or referencing an issue to reduce noise and improve readability.
Suggested change
| // TODO: the feedback is disabled for now, as it was causing a deadlock | |
| // when the engine was blocked on sending a new event to the feedbacking signature. | |
| // This is because the engine would eventually block on trying to to send | |
| // a new event to the feedbacking signature. This would cause a deadlock | |
| // there - propagating back to the engine and pipeline in general. | |
| // We should keep it here for reference until we find a better solution. | |
| // if !engine.config.Enabled { | |
| // return | |
| // // next section is relevant only for engine-in-pipeline and analyze | |
| // } | |
| // e, err := findings.FindingToEvent(res) | |
| // if err != nil { | |
| // logger.Errorw("Failed to convert finding to event, will not feedback", "err", err) | |
| // return | |
| // } | |
| // prot := e.ToProtocol() | |
| // engine.inputs.Tracee <- prot | |
| // TODO: The feedback mechanism was disabled due to a deadlock issue. Refer to issue tracker for details. |
Copilot uses AI. Check for mistakes.
Comment on lines
+164
to
+165
| // prot := e.ToProtocol() | ||
| // engine.inputs.Tracee <- prot |
There was a problem hiding this comment.
To avoid potential deadlocks when re-enabling feedback, consider making this send non-blocking (e.g., using a select with a default case or buffering the channel).
Suggested change
| // prot := e.ToProtocol() | |
| // engine.inputs.Tracee <- prot | |
| prot := e.ToProtocol() | |
| select { | |
| case engine.inputs.Tracee <- prot: | |
| // Successfully sent to the channel | |
| default: | |
| logger.Warnw("Failed to send event to Tracee input channel, dropping event") | |
| } |
Copilot uses AI. Check for mistakes.
geyslan
approved these changes
Jun 23, 2025
c59f4c4 to
5c806a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
5fdc7f3 PR #4803: fix(engine):disable feedback
2. Explain how to test it
3. Other comments