-
Notifications
You must be signed in to change notification settings - Fork 26.5k
Add unit test for PublishMetadata, Version command #7906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f0398ee
Add unit test for Ready,PublishMetadata,Version command
BurningCN a73a607
Add clear mechanism in unit test
BurningCN 2367a58
Fix unit test
BurningCN 05086fd
Fix unit test
BurningCN 51aebf9
Fix unit test
BurningCN 1aefe6c
Fix unit test npe
BurningCN 0f29279
Fix unit test
BurningCN 675bcab
Fix unit test
BurningCN dde670a
Debug ut
BurningCN 22f2ca5
Fix ut
BurningCN ca68ced
Debug ut
BurningCN 6bd212c
Debug ut
BurningCN bed205d
Debug ut
8000
BurningCN 64b62c3
Debug ut
BurningCN abb9068
Debug ut
BurningCN b872299
Revert
BurningCN b934515
Debug ut
BurningCN 98e693a
Debug ut
BurningCN 95e85dc
Remove ReadyTest
BurningCN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
...plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/PublishMetadataTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.dubbo.qos.command.impl; | ||
|
||
import org.apache.dubbo.config.ApplicationConfig; | ||
import org.apache.dubbo.rpc.model.ApplicationModel; | ||
import org.junit.jupiter.api.AfterEach; | ||
import org.junit.jupiter.api.Assertions; | ||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.Test; | ||
|
||
public class PublishMetadataTest { | ||
|
||
@BeforeEach | ||
public void setUp() { | ||
ApplicationModel.getConfigManager().setApplication(new ApplicationConfig("app")); | ||
} | ||
|
||
@AfterEach | ||
public void clear(){ | ||
ApplicationModel.reset(); | ||
} | ||
|
||
@Test | ||
public void testNoDelay() { | ||
PublishMetadata publishMetadata = new PublishMetadata(); | ||
String msg = publishMetadata.execute(null, null); | ||
Assertions.assertEquals(msg, "publish metadata succeeded."); | ||
} | ||
|
||
@Test | ||
public void testWithDelay() { | ||
PublishMetadata publishMetadata = new PublishMetadata(); | ||
String[] args = {"10"}; | ||
String msg = publishMetadata.execute(null, args); | ||
Assertions.assertEquals(msg,"publish task submitted, will publish in " + args[0] + " seconds."); | ||
} | ||
} |
29 changes: 29 additions & 0 deletions
29
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/VersionTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.dubbo.qos.command.impl; | ||
|
||
import org.junit.jupiter.api.Assertions; | ||
import org.junit.jupiter.api.Test; | ||
|
||
public class VersionTest { | ||
@Test | ||
public void test(){ | ||
Version version = new Version(); | ||
String msg = version.execute(null,null); | ||
Assertions.assertNotNull(msg); | ||
} | ||
} |
21 changes: 21 additions & 0 deletions
21
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/support/DemoService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.dubbo.qos.command.support; | ||
|
||
public interface DemoService { | ||
void sayHello(String name); | ||
} |
26 changes: 26 additions & 0 deletions
26
...in/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/support/impl/DemoServiceImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.dubbo.qos.command.support.impl; | ||
|
||
import org.apache.dubbo.qos.command.support.DemoService; | ||
|
||
public class DemoServiceImpl implements DemoService { | ||
@Override | ||
public void sayHello(String name) { | ||
System.out.println("hello :" + name); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.